From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [net-next PATCH] net: dcb: add CEE notify calls Date: Mon, 23 Apr 2012 09:12:00 -0700 Message-ID: <4F957F50.6040704@intel.com> References: <20120420194923.8103.54825.stgit@jf-dev1-dcblab> <1335185512.15423.10.camel@lb-tlvb-shmulik.il.broadcom.com> <4F955AE8.6040802@intel.com> <1335200401.15423.18.camel@lb-tlvb-shmulik.il.broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, netdev@vger.kernel.org, eilong@broadcom.com, amirv@dev.mellanox.co.il To: Shmulik Ravid Return-path: Received: from mga11.intel.com ([192.55.52.93]:53483 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752287Ab2DWQMC (ORCPT ); Mon, 23 Apr 2012 12:12:02 -0400 In-Reply-To: <1335200401.15423.18.camel@lb-tlvb-shmulik.il.broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: On 4/23/2012 10:00 AM, Shmulik Ravid wrote: > >> No. We want all the firmware agents and host based agents to look the >> same from the application. The situation you described is exactly the >> same for user space as in firmware. The DCBx state machine starts and may >> call dcbnl_setxxx with initial (local) values. At some later point these >> may change (possibly because of negotiation with a peer) and we need to >> call dcbnl_setxxx again. >> >> I don't see how this complicates any user mode code? Presumably the agent >> is listening to DCBx events because it really wants to know the current >> state of DCBx. It seems to me skipping notifications will actually cause >> more issues this results in the hardware being in some state that did not >> trigger any events and the agent will now be out of sync. This is the >> problem I am trying to solve. >> >> btw with this patch we can remove the notify calls in bnx2x. >> >> .John >> > OK, I see. >>>From a user mode application monitoring the netlink notification you get > successive updates each indicating the current valid negotiated > parameters (and HW state) and that's fine. > However I don't see how you can remove the notification call form the > bnx2x. When the FW DCBx agent decides to change the negotiated > parameters (perhaps in response to a peer request), it alerts the driver > which configures the HW and then needs to somehow notify the user about > the newly negotiated parameters. > You are right here. I guess only the notify call after setapp can be removed. Can you ACK the patch to indicate this addresses your concerns? .John > Shmulik > >