From: Or Gerlitz <ogerlitz@mellanox.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <shlomop@mellanox.com>
Subject: Re: [PATCH net] net/neigh: move neigh cleanup routine to neigh_destroy
Date: Tue, 24 Apr 2012 13:05:09 +0300 [thread overview]
Message-ID: <4F967AD5.3010807@mellanox.com> (raw)
In-Reply-To: <20120424.005309.2292973770816115829.davem@davemloft.net>
On 4/24/2012 7:53 AM, David Miller wrote:
> With IPOIB, the neigh_cleanup purges references to the neigh when it
> liberates the SKBs in the neigh resolution TX backlog during
> ipoib_neigh_free(). Therefore, with your change, IPOIB neighs will
> never be destroyed if they have any SKBs in their neigh resolution
> queues. I'm not applying this, it's buggy.
Oh yes indeed, so we will need to address that dependency too when
coming to fix the ipoib neigh related races, thanks for spotting this over.
Or.
prev parent reply other threads:[~2012-04-24 10:05 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-23 15:34 [PATCH net] net/neigh: move neigh cleanup routine to neigh_destroy Or Gerlitz
2012-04-24 4:53 ` David Miller
2012-04-24 10:05 ` Or Gerlitz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F967AD5.3010807@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=shlomop@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).