From: Shan Wei <shanwei88@gmail.com>
To: Stephen Hemminger <shemminger@vyatta.com>
Cc: xemul@parallels.com, NetDev <netdev@vger.kernel.org>
Subject: Re: [PATCH 2/2] ss: implement -M option to get all memory information
Date: Fri, 27 Apr 2012 10:04:17 +0800 [thread overview]
Message-ID: <4F99FEA1.2000700@gmail.com> (raw)
In-Reply-To: <20120425104128.4d6e13e1@nehalam.linuxnetplumber.net>
Stephen Hemminger said, at 2012/4/26 1:41:
>> " -m, --memory show socket memory usage\n"
>> +" -M, --skmem show socket memory information.\n"
>> +" this option which will replace -m, is valid since Linux 3.3.\n"
>
> Please don't add reference to kernel version.
> Why does this need to be a new option? Maybe just do the right thing
> if present in the netlink response?
Actually, I'm ok for your suggestion that using a existing option(-m) to
export all memory information. But with a new option is better for us.
Maybe some people use latest iproute source with under kernel 3.3.0, some don't.
-m option will take different user experience, specially for UDP socket.
Currently -m option has no effect on UDP socket which i will submit another patch
to export memory information for. new option, fresh experience.
(Exporting out memory information will help us to analysis dropped packets
which recorded in RcvbufErrors and SndbufErrors.)
next prev parent reply other threads:[~2012-04-27 2:03 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 7:15 [PATCH 2/2] ss: implement -M option to get all memory information Shan Wei
2012-04-25 17:41 ` Stephen Hemminger
2012-04-27 2:04 ` Shan Wei [this message]
2012-04-27 17:21 ` Stephen Hemminger
2012-05-02 9:45 ` Shan Wei
2012-05-02 19:00 ` Stephen Hemminger
2012-05-03 8:37 ` Pavel Emelyanov
2012-05-03 8:39 ` Shan Wei
2012-05-03 15:25 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F99FEA1.2000700@gmail.com \
--to=shanwei88@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=shemminger@vyatta.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).