From: Karsten Keil <kkeil@linux-pingi.de>
To: David Laight <David.Laight@ACULAB.COM>
Cc: Karsten Keil <isdn@linux-pingi.de>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org, isdn4linux@listserv.isdn4linux.de
Subject: Re: [PATCH 23/28] mISDN: Fix compiler warnings
Date: Sat, 28 Apr 2012 12:03:16 +0200 [thread overview]
Message-ID: <4F9BC064.4070608@linux-pingi.de> (raw)
In-Reply-To: <AE90C24D6B3A694183C094C60CF0A2F6026B6EEE@saturn3.aculab.com>
Hi David,
thanks for the review.
Am 24.04.2012 10:24, schrieb David Laight:
>
>> diff --git a/drivers/isdn/hardware/mISDN/hfcmulti.c
>> b/drivers/isdn/hardware/mISDN/hfcmulti.c
>> index 884c090..144c35a 100644
>> --- a/drivers/isdn/hardware/mISDN/hfcmulti.c
>> +++ b/drivers/isdn/hardware/mISDN/hfcmulti.c
>> @@ -2456,12 +2456,12 @@ handle_timer_irq(struct hfc_multi *hc)
>> spin_unlock_irqrestore(&HFClock, flags);
>> }
>> if (test_bit(HFC_CHIP_2MBITRAW, &hc->chip)) {
>> - if (hc->created[hc->chan[0].port] && hc->chan[ch].bch &&
>> + ch = 0;
>> + if (hc->created[hc->chan[ch].port] &&
>> hc->chan[ch].bch &&
>> test_bit(FLG_ACTIVE, &hc->chan[ch].bch->Flags)) {
>> ch_activ++;
>> - hfcmulti_tx(hc, 0);
>> - hfcmulti_rx(hc, 0);
>> - ch = 1;
>> + hfcmulti_tx(hc, ch);
>> + hfcmulti_rx(hc, ch);
>> if (hc->chan[ch].dch &&
>> hc->chan[ch].nt_timer > -1) {
>> dch = hc->chan[ch].dch;
>
> That seems to change the fields checked in the final 'if'.
> Not sure it is the intended behaviour.
>
Yes it is the correct behavior, it was wrong before. If the
HFC_CHIP_2MBITRAW flag is set, only hc->chan[0] should be used.
This did not make trouble, because you normally do not use any
D-channnel in 2 MBit mode, calling the D-Channel specific functions
still makes sense for the L1 state machine, when using this
mode to emulate a E1 Layer1 tester, which was the main reson to
implement this mode.
Karsten
prev parent reply other threads:[~2012-04-28 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-21 15:49 [PATCH 23/28] mISDN: Fix compiler warnings Karsten Keil
2012-04-24 8:24 ` David Laight
2012-04-28 10:03 ` Karsten Keil [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9BC064.4070608@linux-pingi.de \
--to=kkeil@linux-pingi.de \
--cc=David.Laight@ACULAB.COM \
--cc=davem@davemloft.net \
--cc=isdn4linux@listserv.isdn4linux.de \
--cc=isdn@linux-pingi.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).