From mboxrd@z Thu Jan  1 00:00:00 1970
From: Jan Seiffert <kaffeemonster@googlemail.com>
Subject: Re: [REGRESSION][PATCH V4 3/3] bpf jit: Let the powerpc jit handle
 negative offsets
Date: Tue, 1 May 2012 02:44:16 +0200
Message-ID: <4F9F31E0.5020308@googlemail.com>
References: <1335760199.20866.33.camel@pasglop>  <4F9E188E.80503@googlemail.com> <1335763568.20866.37.camel@pasglop>  <20120430.134140.1738751315208907289.davem@davemloft.net>  <1335822926.20866.47.camel@pasglop> <1335823049.20866.48.camel@pasglop>  <4F9F12ED.1090009@googlemail.com> <1335831987.20866.93.camel@pasglop>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: QUOTED-PRINTABLE
Cc: David Miller <davem@davemloft.net>, <eric.dumazet@gmail.com>,
	<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>
To: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Return-path: <linux-kernel-owner@vger.kernel.org>
In-Reply-To: <1335831987.20866.93.camel@pasglop>
Sender: linux-kernel-owner@vger.kernel.org
List-Id: netdev.vger.kernel.org

Benjamin Herrenschmidt schrieb:
> On Tue, 2012-05-01 at 00:32 +0200, Jan Seiffert wrote:
>=20
>> *shudder*
>> Link to another lib for only one function because....
>>
>> http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/net/bpf.h?rev=3D1.59&con=
tent-type=3Dtext/x-cvsweb-markup&only_with_tag=3DMAIN
>> The "Original" says it's an u_int.
>>
>> But i guess it is unfixable without breaking something, except with =
ugly code.
>> Should the padding at least be made explicit in the in-kernel struct=
?
>> Did anyone ever tested the 32bit on 64bit compat code (different pad=
ding)?
>=20
> Haven't tested no. A quick google pointed to 2 web pages telling peop=
le
> to do the wrong thing and 4 broken programs out there, interestingly =
in
> different ways :-) (somebody's doing a reinterpret_cast of one struct
> into another, somebody does his/her own local redefinition of the
> struct ... using a ulong !, etc....)
>=20

Ouch!

> I don't see a good way to sort that out other than introducing a new
> kernel-side structure, change the sockopt number, and support the old
> one as backward binary compat, but that's gross.
>=20

But a sane way forward?

BTW, has anyone checked the new syscall filter code for these ... misfo=
rtunes?
I mean before the ABI is set in stone...

> Cheers,
> Ben.
>=20
>=20
>=20

Greetings
	Jan

--=20
=F0=9F=98=89=20