netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sekhar Nori <nsekhar@ti.com>
To: <hs@denx.de>
Cc: "davinci-linux-open-source@linux.davincidsp.com"
	<davinci-linux-open-source@linux.davincidsp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"devicetree-discuss@lists.ozlabs.org"
	<devicetree-discuss@lists.ozlabs.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Grant Likely <grant.likely@secretlab.ca>,
	Wolfgang Denk <wd@denx.de>, Anatoly Sivov <mm05@mail.ru>
Subject: Re: [PATCH v3 4/7] ARM: davinci: net: davinci_emac: add OF support
Date: Thu, 17 May 2012 12:51:00 +0530	[thread overview]
Message-ID: <4FB4A6DC.20208@ti.com> (raw)
In-Reply-To: <4FB49B7B.60506@denx.de>

On 5/17/2012 12:02 PM, Heiko Schocher wrote:
> Nori, Sekhar wrote:
>> On Mon, Mar 05, 2012 at 16:40:01, Heiko Schocher wrote:

>>> +#ifdef CONFIG_OF
>>> +static struct emac_platform_data
>>> +	*davinci_emac_of_get_pdata(struct platform_device *pdev,
>>> +	struct emac_priv *priv)
>>> +{
>>> +	struct device_node *np;
>>> +	struct device_node *pinmux_np;
>>> +	struct emac_platform_data *pdata = NULL;
>>> +	const u8 *mac_addr;
>>> +	u32 data;
>>> +	int ret;
>>> +	int version;
>>> +
>>> +	np = pdev->dev.of_node;
>>> +	if (!np)
>>> +		goto nodata;
>>> +	else
>>> +		version = EMAC_VERSION_2;
>>
>> You could set pdata->version directly here. 
> 
> done.

Just noticed that pdata is not setup at this time. I guess you will be
moving around some code to do this.

>>> +
>>> +	pinmux_np = of_parse_phandle(np, "pinmux-handle", 0);
>>> +	if (pinmux_np)
>>> +		davinci_cfg_reg_of(pinmux_np);
>>
>> This is a DaVinci specific pinmux function and this
>> driver can be used in non-DaVinci platforms like C6x
>> and OMAP. So, it will not be correct to call a DaVinci
>> specific function here.
> 
> Ah, right!
> 
>> Can you drop the pinmux from this patch for now? On DaVinci,
> 
> Done ... Hmm.. so I think, I should drop this for all patches
> from my patchset, right?

Yes.

> 
>> for pinmux, we need to migrate to drivers/pinctrl/ as well.
> 
> Ah, I see ... take a look at it, maybe I find time to do here
> something ... or do you know about work in progress here?

There is no work in progress within TI. So, if you are interested in
taking a stab it it, it will be great.

> 
>> Doing this will also make this patch independent of the rest
>> of this series can even be merged separately. Can you please
>> make these changes and resend just this patch?
> 
> Yep, I do some test with the changes you requested and resend
> this patch ... do you prefer some tree, which I should use as
> base?

This one should ideally merge through the network subsystem so may be
base it on the net-next tree?

http://git.kernel.org/?p=linux/kernel/git/davem/net-next.git;a=summary

Thanks,
Sekhar

  reply	other threads:[~2012-05-17  7:21 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-05 11:09 [PATCH v3 0/7] ARM: davinci: add support for the am1808 based enbw_cmc board Heiko Schocher
2012-03-05 11:10 ` [PATCH v3 4/7] ARM: davinci: net: davinci_emac: add OF support Heiko Schocher
2012-05-15 18:08   ` Nori, Sekhar
2012-05-17  6:32     ` Heiko Schocher
2012-05-17  7:21       ` Sekhar Nori [this message]
     [not found] ` <1330945804-3379-1-git-send-email-hs-ynQEQJNshbs@public.gmane.org>
2012-03-05 11:10   ` [PATCH v3 7/7] ARM: davinci: add support for the am1808 based enbw_cmc board Heiko Schocher
2012-05-04 15:33   ` [PATCH v3 0/7] " Heiko Schocher
     [not found]     ` <4FA3F6C2.9010602-ynQEQJNshbs@public.gmane.org>
2012-05-04 18:36       ` Sekhar Nori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FB4A6DC.20208@ti.com \
    --to=nsekhar@ti.com \
    --cc=davinci-linux-open-source@linux.davincidsp.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=hs@denx.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mm05@mail.ru \
    --cc=netdev@vger.kernel.org \
    --cc=wd@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).