From: Xiao Jiang <jgq516@gmail.com>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: steve.glendinning@smsc.com, gregkh@linuxfoundation.org,
netdev@vger.kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1] smsc95xx: add FLAG_POINTTOPOINT flag for driver_info
Date: Thu, 17 May 2012 16:40:46 +0800 [thread overview]
Message-ID: <4FB4B98E.7000208@gmail.com> (raw)
In-Reply-To: <1337168320.4107.42.camel@deadeye>
Ben Hutchings wrote:
> On Wed, 2012-05-16 at 16:01 +0800, jgq516@gmail.com wrote:
>
>> From: Xiao Jiang <jgq516@gmail.com>
>>
>> commit c26134 introduced FLAG_POINTTOPOINT flag for USB ethernet devices
>> which possibly use "usb%d" names, add this flag to make sure pandaboard
>> can mount nfs with smsc95xx NIC.
>>
>
> These are normal Ethernet interfaces, whereas FLAG_POINTTOPOINT is for
> devices that use non-standard short physical links.
>
>
This flag is used by some usb NICs, I amn't familiar with those cards
perhaps those are
non-standard short physical links as you said.
But smsc95xx seems need this flag to use "usb%d" name, at least my
pandaboard can't
mount nfs with eth0 name, is there other ways to avoid nfs issue with
keep smsc95xx's
name unchange? thanks.
-bash-3.2$ grep FLAG_POINTTOPOINT * -r
drivers/net/usb/zaurus.c: .flags = FLAG_POINTTOPOINT | FLAG_FRAMING_Z,
drivers/net/usb/zaurus.c: .flags = FLAG_POINTTOPOINT | FLAG_FRAMING_Z,
drivers/net/usb/zaurus.c: .flags = FLAG_POINTTOPOINT | FLAG_FRAMING_Z,
drivers/net/usb/zaurus.c: .flags = FLAG_POINTTOPOINT | FLAG_FRAMING_Z,
drivers/net/usb/cdc_ncm.c: .flags = FLAG_POINTTOPOINT |
FLAG_NO_SETINT | FLAG_MULTI_PACKET,
drivers/net/usb/gl620a.c: .flags = FLAG_POINTTOPOINT |
FLAG_FRAMING_GL | FLAG_NO_SETINT,
drivers/net/usb/plusb.c: .flags = FLAG_POINTTOPOINT | FLAG_NO_SETINT,
drivers/net/usb/usbnet.c: ((dev->driver_info->flags &
FLAG_POINTTOPOINT) == 0 ||
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_subset.c: .flags = FLAG_POINTTOPOINT,
drivers/net/usb/cdc_eem.c: .flags = FLAG_ETHER | FLAG_POINTTOPOINT,
drivers/net/usb/rndis_host.c: .flags = FLAG_ETHER |
FLAG_POINTTOPOINT | FLAG_FRAMING_RN | FLAG_NO_SETINT,
drivers/net/usb/rndis_host.c: .flags = FLAG_ETHER |
FLAG_POINTTOPOINT | FLAG_FRAMING_RN | FLAG_NO_SETINT,
drivers/net/usb/cdc_ether.c: .flags = FLAG_ETHER | FLAG_POINTTOPOINT,
drivers/net/usb/net1080.c: .flags = FLAG_POINTTOPOINT |
FLAG_FRAMING_NC,
include/linux/usb/usbnet.h:#define FLAG_POINTTOPOINT 0x1000 /*
possibly use "usb%d" names */
Regards,
Xiao
> Ben.
>
>
>> Signed-off-by: Xiao Jiang <jgq516@gmail.com>
>> ---
>> drivers/net/usb/smsc95xx.c | 3 ++-
>> 1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> diff --git a/drivers/net/usb/smsc95xx.c b/drivers/net/usb/smsc95xx.c
>> index 94ae669..e158288 100644
>> --- a/drivers/net/usb/smsc95xx.c
>> +++ b/drivers/net/usb/smsc95xx.c
>> @@ -1192,7 +1192,8 @@ static const struct driver_info smsc95xx_info = {
>> .rx_fixup = smsc95xx_rx_fixup,
>> .tx_fixup = smsc95xx_tx_fixup,
>> .status = smsc95xx_status,
>> - .flags = FLAG_ETHER | FLAG_SEND_ZLP | FLAG_LINK_INTR,
>> + .flags = FLAG_ETHER | FLAG_POINTTOPOINT | FLAG_SEND_ZLP |
>> + FLAG_LINK_INTR,
>> };
>>
>> static const struct usb_device_id products[] = {
>>
>
>
next prev parent reply other threads:[~2012-05-17 8:40 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-16 8:01 [PATCH 1/1] smsc95xx: add FLAG_POINTTOPOINT flag for driver_info jgq516-Re5JQEeQqe8AvxtiuMwx3w
[not found] ` <1337155302-26244-1-git-send-email-jgq516-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-05-16 11:38 ` Ben Hutchings
2012-05-17 8:40 ` Xiao Jiang [this message]
2012-05-17 11:45 ` Ben Hutchings
2012-05-16 11:56 ` Ming Lei
2012-05-17 2:23 ` Xiao Jiang
2012-05-17 8:20 ` Ming Lei
2012-05-17 9:51 ` Xiao Jiang
2012-05-16 13:10 ` Sergei Shtylyov
2012-05-17 8:06 ` Xiao Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FB4B98E.7000208@gmail.com \
--to=jgq516@gmail.com \
--cc=ben@decadent.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=steve.glendinning@smsc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).