From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH (net.git) 1/4] stmmac: remove two useless initialisation
Date: Mon, 04 Jun 2012 17:58:18 +0200 [thread overview]
Message-ID: <4FCCDB1A.1080307@st.com> (raw)
In-Reply-To: <20120604.114940.813410325113851773.davem@davemloft.net>
On 6/4/2012 5:49 PM, David Miller wrote:
> From: Giuseppe CAVALLARO <peppe.cavallaro@st.com>
> Date: Mon, 4 Jun 2012 17:37:47 +0200
>
>> This patch removes two useful initialisation in the
>> stmmac_rx and stmmac_tx function.
>> In the former, count var was already reset and in the
>> stmmac_tx we only need to increment the dirty pointer
>> w/o setting the entry var.
>>
>> Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
>
> There are so many problems with this patch I do not know where
> to start.
>
> Your subject line says the initializations are "useless" yet
> your commit message says they are "useful".
Sorry, I meant "useless".
> This is a cleanup, and does not fix any bugs, and is therefore
> absolutely not appropriate for the 'net' tree.
Yes this is not a fix but a cleanup.
I've not clear where I have to post this patch.
Do you mean, w/o net.git entry in the patch subject?
Can you tell me what I have to do? So will resend all the patches again
but I'll be more careful on all.
> I'm tossing this entire series, you need to be more careful
> with your submissions.
ok, thanks a lot.
peppe
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
>
next prev parent reply other threads:[~2012-06-04 15:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 15:37 [PATCH (net.git) 0/4] stmmac fixes for net.git Giuseppe CAVALLARO
2012-06-04 15:37 ` [PATCH (net.git) 1/4] stmmac: remove two useless initialisation Giuseppe CAVALLARO
2012-06-04 15:49 ` David Miller
2012-06-04 15:58 ` Giuseppe CAVALLARO [this message]
2012-06-04 16:01 ` David Miller
2012-06-04 16:31 ` Giuseppe CAVALLARO
2012-06-04 15:37 ` [PATCH (net.git) 2/4] stmmac: fix driver's doc when run kernel-doc script Giuseppe CAVALLARO
2012-06-04 15:37 ` [PATCH (net.git) 3/4] stmmac: update driver's doc Giuseppe CAVALLARO
2012-06-04 15:37 ` [PATCH (net.git) 4/4 (v2)] stmmac: fix driver Kconfig when built as module Giuseppe CAVALLARO
[not found] ` <CAJ3bTp5ASPyQAqB0CZV1E17uDMpgefQE9pZcPRHbcDMCgeprDg@mail.gmail.com>
2012-06-05 5:41 ` Giuseppe CAVALLARO
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCCDB1A.1080307@st.com \
--to=peppe.cavallaro@st.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).