netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jan Ceuleers <jan.ceuleers@computer.org>
To: David Miller <davem@davemloft.net>
Cc: b06378@freescale.com, joe@perches.com, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 5/5] gianfar_ethtool: coding style and whitespace cleanups
Date: Mon, 04 Jun 2012 21:11:09 +0200	[thread overview]
Message-ID: <4FCD084D.6020408@computer.org> (raw)
In-Reply-To: <20120604.140850.1847853625568125563.davem@davemloft.net>

On 06/04/2012 08:08 PM, David Miller wrote:
> From: Jan Ceuleers <jan.ceuleers@computer.org>
> Date: Mon,  4 Jun 2012 18:31:56 +0200
> 
>> -					sizeof(struct gfar_mask_entry),
>> -					gfar_comp, &gfar_swap);
>> +			     sizeof(struct gfar_mask_entry),
>> +			     far_comp, &gfar_swap);
> 
> Don't send me crap you haven't even compile tested.
> 
> I'm tossing this entire patch series out, don't resubmit until you've
> tested every single patch.
> 

Well then I'm sorry but I won't be resubmitting

  reply	other threads:[~2012-06-04 19:14 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-04 16:31 [PATCH net-next 0/5] gianfar: coding style cleanups Jan Ceuleers
2012-06-04 16:31 ` [PATCH net-next 1/5] gianfar: whitespace cleanup - pointers Jan Ceuleers
2012-06-04 16:31 ` [PATCH net-next 2/5] gianfar: comment cleanup Jan Ceuleers
2012-06-04 16:31 ` [PATCH net-next 3/5] gianfar: various coding style and whitespace cleanups Jan Ceuleers
2012-06-04 16:31 ` [PATCH net-next 4/5] gianfar: Remove superfluous initialisations Jan Ceuleers
2012-06-04 16:31 ` [PATCH net-next 5/5] gianfar_ethtool: coding style and whitespace cleanups Jan Ceuleers
2012-06-04 18:08   ` David Miller
2012-06-04 19:11     ` Jan Ceuleers [this message]
2012-06-04 19:52       ` David Miller
2012-06-05  5:54         ` Jan Ceuleers
2012-06-05  9:14           ` David Miller
2012-06-05 10:49             ` Jan Ceuleers
2012-06-05 10:54               ` Florian Fainelli
2012-06-05 11:10                 ` Eric Dumazet
2012-06-05 13:42                 ` Jan Ceuleers
2012-06-05 21:38                 ` David Miller
2012-06-05 21:37               ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FCD084D.6020408@computer.org \
    --to=jan.ceuleers@computer.org \
    --cc=b06378@freescale.com \
    --cc=davem@davemloft.net \
    --cc=joe@perches.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).