From: "Yuval Mintz" <yuvalmin@broadcom.com>
To: "Giuseppe CAVALLARO" <peppe.cavallaro@st.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"Eilon Greenstein" <eilong@broadcom.com>
Subject: Re: [net-next PATCH 1/3] Added kernel support in EEE Ethtool commands
Date: Tue, 5 Jun 2012 11:11:26 +0300 [thread overview]
Message-ID: <4FCDBF2E.6040705@broadcom.com> (raw)
In-Reply-To: <4FCDBCBA.8040306@st.com>
On 06/05/2012 11:00 AM, Giuseppe CAVALLARO wrote:
> Hello Yuval,
>
> On 6/5/2012 8:39 AM, Yuval Mintz wrote:
>> This patch extends the kernel's ethtool interface by adding support
>> for 2 new EEE commands - get_eee and set_eee.
>
>> + __u32 tx_lpi_enabled;
>> + __u32 tx_lpi_timer;
>
> Is the tx_lpi_timer field for the MAC driver as we discussed in the
> past? If yes, so I can use it for the stmmac too.
>
> Peppe
>
Hi Peppe,
The short answer is yes.
The API does not specify whether the delay should be made in the MAC
or controller levels, but it should guarantee that if the nic is idle
it should wait that many microseconds prior to asserting its Tx lpi.
Thanks,
Yuval
next prev parent reply other threads:[~2012-06-05 8:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-05 6:38 [net-next PATCH 0/3] Energy Efficient Ethernet (eee) support Yuval Mintz
2012-06-05 6:39 ` [net-next PATCH 1/3] Added kernel support in EEE Ethtool commands Yuval Mintz
2012-06-05 8:00 ` Giuseppe CAVALLARO
2012-06-05 8:11 ` Yuval Mintz [this message]
2012-06-05 8:16 ` Giuseppe CAVALLARO
2012-06-05 19:01 ` Ben Hutchings
2012-06-05 6:39 ` [net-next PATCH 2/3] bnx2x: Added EEE support Yuval Mintz
2012-06-05 6:39 ` [net-next PATCH 3/3] bnx2x: Added EEE Ethtool support Yuval Mintz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCDBF2E.6040705@broadcom.com \
--to=yuvalmin@broadcom.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).