From: John Fastabend <john.r.fastabend@intel.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: Tom Herbert <therbert@google.com>,
David Miller <davem@davemloft.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] bonding: Fix corrupted queue_mapping
Date: Fri, 08 Jun 2012 09:16:15 -0700 [thread overview]
Message-ID: <4FD2254F.1090900@intel.com> (raw)
In-Reply-To: <1339168272.6001.116.camel@edumazet-glaptop>
On 6/8/2012 8:11 AM, Eric Dumazet wrote:
> On Fri, 2012-06-08 at 08:04 -0700, Tom Herbert wrote:
>
>> Maybe the fundamental issue is that the queue mappings only allow for
>> one level of multi queue device. It might be better if bonding didn't
>> have one and dev_pick_tx did the right thin (use xps on bonding
>> maybe).
>
> bonding misuses multiqueue infrastructure to divert frames on selected
> slaves, or maybe I am wrong.
>
This is right see bond_slave_override() here the slaves queue_ids
are mapped to skb->queue_mapping via this TX_QUEUE_OVERRIDE param.
next prev parent reply other threads:[~2012-06-08 16:16 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-08 5:05 [PATCH] bonding: Fix corrupted queue_mapping Tom Herbert
2012-06-08 5:46 ` David Miller
2012-06-08 5:57 ` Eric Dumazet
2012-06-08 6:02 ` David Miller
2012-06-08 6:11 ` Eric Dumazet
2012-06-08 6:15 ` David Miller
2012-06-08 6:47 ` Eric Dumazet
2012-06-08 7:23 ` Eric Dumazet
2012-06-08 7:42 ` John Fastabend
2012-06-08 7:48 ` Eric Dumazet
2012-06-08 7:52 ` Eric Dumazet
2012-06-08 7:46 ` Eric Dumazet
2012-06-08 15:04 ` Tom Herbert
2012-06-08 15:11 ` Eric Dumazet
2012-06-08 16:16 ` John Fastabend [this message]
2012-06-08 6:17 ` Eric Dumazet
2012-06-08 6:22 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD2254F.1090900@intel.com \
--to=john.r.fastabend@intel.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=therbert@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).