From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wolfgang Grandegger Subject: Re: [PATCH RFC] c_can_pci: generic module for c_can on PCI Date: Mon, 11 Jun 2012 16:21:19 +0200 Message-ID: <4FD5FEDF.6020405@grandegger.com> References: <331ABD5ECB02734CA317220B2BBEABC13E9CB18A@DBDE01.ent.ti.com> <4FCE07EE.40003@pengutronix.de> <4FC135C6.5030206@grandegger.com> <1677842.Pq7naXsvrI@harkonnen> <3650428.HarNR9HfNF@harkonnen> <20120605131337.GA15432@mail.gnudd.com> <20120605133013.GA16108@mail.gnudd.com> <20120605165008.GA21871@mail.gnudd.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Bhupesh SHARMA , "rubini@gnudd.com" , "anilkumar@ti.com" , "mkl@pengutronix.de" , "alan@lxorguk.ukuu.org.uk" , Giancarlo ASNAGHI , "alan@linux.intel.com" , "linux-can@vger.kernel.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" To: Federico Vaga Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 06/11/2012 03:18 PM, Federico Vaga wrote: > How we proceed? > I submit my c_can_pci.c as a separated module, we create a > c_can_platform_common.c, > or we are thinking about a generic c_can.c as plaftorm driver? I would accept your patch with the remaining fixes especially the new register access methods introduced by the D_CAN support patch recently. Any further improvements to the device abstraction and a more consistent handling of the platform data or register access should be addressed by sub-sequent patches. Wolfgang.