From mboxrd@z Thu Jan 1 00:00:00 1970 From: Weiping Pan Subject: Re: [PATCH net 1/3] bonding:record primary when modify it via sysfs Date: Tue, 12 Jun 2012 11:38:04 +0800 Message-ID: <4FD6B99C.7020305@gmail.com> References: <84a4e0e6bbdc9206baefb1454324f4759a98b80e.1339404887.git.wpan@redhat.com> <4FD64938.6080009@gmail.com> <31624.1339447734@death.nxdomain> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: =?UTF-8?B?Tmljb2xhcyBkZSBQZXNsb8O8YW4=?= , Weiping Pan , netdev@vger.kernel.org To: Jay Vosburgh Return-path: Received: from mail-pz0-f46.google.com ([209.85.210.46]:37117 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751175Ab2FLDdV (ORCPT ); Mon, 11 Jun 2012 23:33:21 -0400 Received: by dady13 with SMTP id y13so6262492dad.19 for ; Mon, 11 Jun 2012 20:33:20 -0700 (PDT) In-Reply-To: <31624.1339447734@death.nxdomain> Sender: netdev-owner@vger.kernel.org List-ID: On 06/12/2012 04:48 AM, Jay Vosburgh wrote: > Nicolas de Peslo=C3=BCan wrote: > >> Le 11/06/2012 11:00, Weiping Pan a =C3=A9crit : >>> If we modify primary via sysfs and it is not a valid slave, >>> we should record it for future use, and this behavior is the same w= ith >>> bond_check_params(). >>> >>> Signed-off-by: Weiping Pan >>> --- >>> drivers/net/bonding/bond_sysfs.c | 8 ++++++-- >>> 1 files changed, 6 insertions(+), 2 deletions(-) >>> >>> diff --git a/drivers/net/bonding/bond_sysfs.c b/drivers/net/bonding= /bond_sysfs.c >>> index aef42f0..485bedb 100644 >>> --- a/drivers/net/bonding/bond_sysfs.c >>> +++ b/drivers/net/bonding/bond_sysfs.c >>> @@ -1082,8 +1082,12 @@ static ssize_t bonding_store_primary(struct = device *d, >>> } >>> } >>> >>> - pr_info("%s: Unable to set %.*s as primary slave.\n", >>> - bond->dev->name, (int)strlen(buf) - 1, buf); >>> + strncpy(bond->params.primary, ifname, IFNAMSIZ); >>> + bond->params.primary[IFNAMSIZ - 1] =3D 0; >>> + >>> + pr_info("%s: Recording %s as primary, " >>> + "but it has not been enslaved to %s yet.\n", >>> + bond->dev->name, ifname, bond->dev->name); >>> out: >>> write_unlock_bh(&bond->curr_slave_lock); >>> read_unlock(&bond->lock); >> I like this one, because it tend to relax the current constraints on= e >> should respect on the order to write into sysfs to setup bonding. >> >> May I suggest we have a better info message, suggesting there might = have a >> typo on the name of the primary ? >> >>> + pr_info("%s: Recording %s as primary, " >>> + "but it has not been enslaved to %s yet. Possible typo?\n", >>> + bond->dev->name, ifname, bond->dev->name); >> Except from this cosmetic, >> >> Acked-by: Nicolas de Peslo=C3=BCan > Agreed, except that I can go either way on the "typo" warning. I prefer not to add 'typo' since I think the log is enough. thanks Weiping Pan > Signed-off-by: Jay Vosburgh > > -J > > --- > -Jay Vosburgh, IBM Linux Technology Center, fubar@us.ibm.com > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html