From: "Shimoda, Yoshihiro" <yoshihiro.shimoda.uh@renesas.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev <netdev@vger.kernel.org>, SH-Linux <linux-sh@vger.kernel.org>
Subject: Re: [PATCH net-next 5/5] net: sh_eth: use NAPI
Date: Tue, 12 Jun 2012 15:47:00 +0900 [thread overview]
Message-ID: <4FD6E5E4.7030702@renesas.com> (raw)
In-Reply-To: <1339480115.22704.20.camel@edumazet-glaptop>
2012/06/12 14:48, Eric Dumazet wrote:
> On Tue, 2012-06-12 at 14:19 +0900, Shimoda, Yoshihiro wrote:
< snip >
>> + if ((mdp->cur_tx - mdp->dirty_tx) >= (mdp->num_tx_ring - 4)) {
>> + if (netif_msg_tx_queued(mdp)) {
>> + dev_warn(&ndev->dev, "TxFD exhausted.\n");
>> + netif_stop_queue(ndev);
>> + }
>> + }
>> +
>> return NETDEV_TX_OK;
>> }
>
>
> I have no idea why you call netif_stop_queue() only if
> netif_msg_tx_queued(mdp)
>
> You should test your driver under heavy TX load.
>
Thank you for the point.
I checked the netif-msg.txt about netif_msg_tx_queued(). It is one of
the network interface message level setting. So, the driver's behavior
should not be changed by the level, I think.
I will modify the patch.
Best regards,
Yoshihiro Shimoda
prev parent reply other threads:[~2012-06-12 6:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-12 5:19 [PATCH net-next 5/5] net: sh_eth: use NAPI Shimoda, Yoshihiro
2012-06-12 5:48 ` Eric Dumazet
2012-06-12 6:47 ` Shimoda, Yoshihiro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD6E5E4.7030702@renesas.com \
--to=yoshihiro.shimoda.uh@renesas.com \
--cc=eric.dumazet@gmail.com \
--cc=linux-sh@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).