From mboxrd@z Thu Jan 1 00:00:00 1970 From: Giuseppe CAVALLARO Subject: Re: [net-next.git 2/4 (v2)] stmmac: do not use strict_strtoul but kstrtoul Date: Wed, 13 Jun 2012 09:41:34 +0200 Message-ID: <4FD8442E.5000601@st.com> References: <1339571827-7162-1-git-send-email-peppe.cavallaro@st.com> <1339571827-7162-3-git-send-email-peppe.cavallaro@st.com> <1339572727.22704.314.camel@edumazet-glaptop> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, bhutchings@solarflare.com, rayagond@vayavyalabs.com, davem@davemloft.net, yuvalmin@broadcom.com To: Eric Dumazet Return-path: Received: from eu1sys200aog105.obsmtp.com ([207.126.144.119]:42105 "EHLO eu1sys200aog105.obsmtp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797Ab2FMHlp (ORCPT ); Wed, 13 Jun 2012 03:41:45 -0400 In-Reply-To: <1339572727.22704.314.camel@edumazet-glaptop> Sender: netdev-owner@vger.kernel.org List-ID: On 6/13/2012 9:32 AM, Eric Dumazet wrote: > On Wed, 2012-06-13 at 09:17 +0200, Giuseppe CAVALLARO wrote: >> This patch replaces the obsolete strict_strtoul with kstrtoul. >> >> v2: also removed casting on kstrtoul. >> >> Signed-off-by: Giuseppe Cavallaro >> --- >> drivers/net/ethernet/stmicro/stmmac/stmmac.h | 2 +- >> drivers/net/ethernet/stmicro/stmmac/stmmac_main.c | 67 +++++++++----------- >> 2 files changed, 31 insertions(+), 38 deletions(-) >> >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac.h b/drivers/net/ethernet/stmicro/stmmac/stmmac.h >> index 6d07ba2..1d70f64 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac.h >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac.h >> @@ -88,7 +88,7 @@ struct stmmac_priv { >> int synopsys_id; >> }; >> >> -extern int phyaddr; >> +extern unsigned long int phyaddr; >> >> extern int stmmac_mdio_unregister(struct net_device *ndev); >> extern int stmmac_mdio_register(struct net_device *ndev); >> diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> index 8899e10..bd53003 100644 >> --- a/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> +++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_main.c >> @@ -80,39 +80,39 @@ >> >> /* Module parameters */ >> #define TX_TIMEO 5000 /* default 5 seconds */ >> -static int watchdog = TX_TIMEO; >> -module_param(watchdog, int, S_IRUGO | S_IWUSR); >> +static unsigned long int watchdog = TX_TIMEO; >> +module_param(watchdog, ulong, S_IRUGO | S_IWUSR); >> MODULE_PARM_DESC(watchdog, "Transmit timeout in milliseconds"); >> > > It seems you missed the kstrtouint() / kstrtoint() functions.... yes i did, I'll resend it again. thanks a lot peppe > > > -- > To unsubscribe from this list: send the line "unsubscribe netdev" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > >