netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Alexander Duyck <alexander.h.duyck@intel.com>
To: Yuval Mintz <yuvalmin@broadcom.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net, eilong@broadcom.com,
	Jeff Kirsher <jeffrey.t.kirsher@intel.com>
Subject: Re: [RFC net-next 07/14] Fix intel/ixgbe
Date: Tue, 19 Jun 2012 08:54:53 -0700	[thread overview]
Message-ID: <4FE0A0CD.5050909@intel.com> (raw)
In-Reply-To: <1340118848-30978-8-git-send-email-yuvalmin@broadcom.com>

On 06/19/2012 08:14 AM, Yuval Mintz wrote:
> Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> ---
>  drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c |    3 ++-
>  1 files changed, 2 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c
> index af1a531..21e4513 100644
> --- a/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c
> +++ b/drivers/net/ethernet/intel/ixgbe/ixgbe_lib.c
> @@ -802,7 +802,8 @@ static int ixgbe_set_interrupt_capability(struct ixgbe_adapter *adapter)
>  	 * The default is to use pairs of vectors.
>  	 */
>  	v_budget = max(adapter->num_rx_queues, adapter->num_tx_queues);
> -	v_budget = min_t(int, v_budget, num_online_cpus());
> +	v_budget = min_t(int, v_budget, min_t(int, num_online_cpus(),
> +					      DEFAULT_MAX_NUM_RSS_QUEUES));
>  	v_budget += NON_Q_VECTORS;
>  
>  	/*
This patch doesn't limit the number of queues.  It is limiting the
number of interrupts.  The two are not directly related as we can
support multiple queues per interrupt.

Also this change assumes we are only using receive side scaling.  We
have other features such as DCB, FCoE, and Flow Director which require
additional queues.

Thanks,

Alex

  reply	other threads:[~2012-06-19 15:54 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-19 15:13 [RFC net-next 00/14] default maximal number of RSS queues in mq drivers Yuval Mintz
2012-06-19 15:13 ` [RFC net-next 01/14] Add Default Yuval Mintz
2012-06-19 16:37   ` Alexander Duyck
2012-06-19 17:41     ` Eilon Greenstein
2012-06-19 19:01       ` Alexander Duyck
2012-06-19 19:53         ` Eilon Greenstein
2012-06-19 21:26         ` David Miller
2012-06-19 21:22     ` David Miller
2012-06-19 15:13 ` [RFC net-next 02/14] Fix mellanox/mlx4 Yuval Mintz
2012-06-19 15:13 ` [RFC net-next 03/14] fix neterion/vxge Yuval Mintz
2012-06-19 15:13 ` [RFC net-next 04/14] Fix qlogic/qlge Yuval Mintz
2012-06-19 15:13 ` [RFC net-next 05/14] Fix intel/ixgbevf Yuval Mintz
2012-06-19 15:39   ` Alexander Duyck
2012-06-19 16:06     ` Eilon Greenstein
2012-06-19 18:07       ` Greg Rose
2012-06-19 18:24         ` Eilon Greenstein
2012-06-25 11:23         ` Yuval Mintz
2012-06-19 15:14 ` [RFC net-next 06/14] Fix intel/igb Yuval Mintz
2012-06-19 15:42   ` Alexander Duyck
2012-06-19 16:07     ` Eilon Greenstein
2012-06-19 15:14 ` [RFC net-next 07/14] Fix intel/ixgbe Yuval Mintz
2012-06-19 15:54   ` Alexander Duyck [this message]
2012-06-19 16:11     ` Eilon Greenstein
2012-06-20  8:55     ` Eric Dumazet
2012-06-20 15:30       ` John Fastabend
2012-06-19 15:14 ` [RFC net-next 08/14] Fix chelsio/cxgb3 Yuval Mintz
2012-06-19 15:14 ` [RFC net-next 09/14] Fix chelsio/cxgb4 Yuval Mintz
2012-06-19 15:14 ` [RFC net-next 10/14] Fix myricom/myri10ge Yuval Mintz
2012-06-19 15:14 ` [RFC net-next 11/14] Fix emulex/benet Yuval Mintz
2012-06-19 22:55   ` Ajit.Khaparde
2012-06-21  6:42   ` Sathya.Perla
2012-06-19 15:14 ` [RFC net-next 12/14] Fix broadcom/tg3 Yuval Mintz
2012-06-19 15:14 ` [RFC net-next 13/14] Fix broadcom/bnx2 Yuval Mintz
2012-06-19 15:14 ` [RFC net-next 14/14] Fix broadcom/bnx2x Yuval Mintz
2012-06-19 16:17 ` [RFC net-next 00/14] default maximal number of RSS queues in mq drivers Eilon Greenstein
2012-06-20 20:43 ` Ben Hutchings
2012-06-20 20:48   ` Ben Hutchings
2012-06-21  5:15     ` Yuval Mintz
2012-06-21  5:49       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FE0A0CD.5050909@intel.com \
    --to=alexander.h.duyck@intel.com \
    --cc=davem@davemloft.net \
    --cc=eilong@broadcom.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=yuvalmin@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).