From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Duyck Subject: Re: [RFC net-next 01/14] Add Default Date: Tue, 19 Jun 2012 09:37:18 -0700 Message-ID: <4FE0AABE.4070100@intel.com> References: <1340118848-30978-1-git-send-email-yuvalmin@broadcom.com> <1340118848-30978-2-git-send-email-yuvalmin@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, davem@davemloft.net, eilong@broadcom.com To: Yuval Mintz Return-path: Received: from mga09.intel.com ([134.134.136.24]:60849 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750955Ab2FSQhe (ORCPT ); Tue, 19 Jun 2012 12:37:34 -0400 In-Reply-To: <1340118848-30978-2-git-send-email-yuvalmin@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: On 06/19/2012 08:13 AM, Yuval Mintz wrote: > Signed-off-by: Yuval Mintz > Signed-off-by: Eilon Greenstein > --- > include/linux/etherdevice.h | 5 ++++- > 1 files changed, 4 insertions(+), 1 deletions(-) > > diff --git a/include/linux/etherdevice.h b/include/linux/etherdevice.h > index 3d406e0..bb1ecaf 100644 > --- a/include/linux/etherdevice.h > +++ b/include/linux/etherdevice.h > @@ -44,7 +44,10 @@ extern int eth_mac_addr(struct net_device *dev, void *p); > extern int eth_change_mtu(struct net_device *dev, int new_mtu); > extern int eth_validate_addr(struct net_device *dev); > > - > +/* The maximal number of RSS queues a driver should have unless configured > + * so explicitly. > + */ > +#define DEFAULT_MAX_NUM_RSS_QUEUES (8) > > extern struct net_device *alloc_etherdev_mqs(int sizeof_priv, unsigned int txqs, > unsigned int rxqs); I'm not a big fan of just having this as a fixed define in the code. It seems like it would make much more sense to have this in the Kconfig somewhere as a range value if you plan on making this changeable in the future. Thanks, Alex