From: Alexander Duyck <alexander.h.duyck@intel.com>
To: Yuval Mintz <yuvalmin@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, eilong@broadcom.com,
Jeff Kirsher <jeffrey.t.kirsher@intel.com>,
Greg Rose <gregory.v.rose@intel.com>
Subject: Re: [RFC net-next (v2) 14/14] ixgbevf: set maximal number of default RSS queues
Date: Mon, 25 Jun 2012 08:45:24 -0700 [thread overview]
Message-ID: <4FE88794.9090704@intel.com> (raw)
In-Reply-To: <1340624745-8650-15-git-send-email-yuvalmin@broadcom.com>
On 06/25/2012 04:45 AM, Yuval Mintz wrote:
> Signed-off-by: Yuval Mintz <yuvalmin@broadcom.com>
> Signed-off-by: Eilon Greenstein <eilong@broadcom.com>
>
> Cc: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
> Cc: Alexander Duyck <alexander.h.duyck@intel.com>
> Cc: Greg Rose <gregory.v.rose@intel.com>
> ---
> drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> index f69ec42..7889644 100644
> --- a/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> +++ b/drivers/net/ethernet/intel/ixgbevf/ixgbevf_main.c
> @@ -2023,7 +2023,7 @@ static int ixgbevf_set_interrupt_capability(struct ixgbevf_adapter *adapter)
> * (roughly) twice the number of vectors as there are CPU's.
> */
> v_budget = min(adapter->num_rx_queues + adapter->num_tx_queues,
> - (int)(num_online_cpus() * 2)) + NON_Q_VECTORS;
> + netif_get_num_default_rss_queues() * 2) + NON_Q_VECTORS;
>
> /* A failure in MSI-X entry allocation isn't fatal, but it does
> * mean we disable MSI-X capabilities of the adapter. */
I'm not even sure why you are bothering to alter this driver since it is
currently single queue only.
Thanks,
Alex
next prev parent reply other threads:[~2012-06-25 15:45 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-25 11:45 [RFC net-next (v2) 00/14] default maximal number of RSS queues in mq drivers Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 01/14] net-next: Add netif_get_num_default_rss_queues Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 02/14] mlx4: set maximal number of default RSS queues Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 03/14] vxge: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 04/14] qlge: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 05/14] cxgb3: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 06/14] cxgb4: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 07/14] myri10ge: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 08/14] tg3: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 09/14] bnx2: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 10/14] bnx2x: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 11/14] igb: " Yuval Mintz
2012-06-25 17:31 ` Vick, Matthew
2012-06-25 18:20 ` Eilon Greenstein
2012-06-25 18:38 ` Ben Hutchings
2012-06-25 11:45 ` [RFC net-next (v2) 12/14] ixgbe: " Yuval Mintz
2012-06-25 15:44 ` Alexander Duyck
2012-06-25 17:53 ` Eilon Greenstein
2012-06-25 18:38 ` Alexander Duyck
2012-06-25 18:44 ` Ben Hutchings
2012-06-25 21:03 ` Alexander Duyck
2012-06-26 11:08 ` Yuval Mintz
2012-06-26 15:55 ` Alexander Duyck
2012-06-26 18:23 ` Eilon Greenstein
2012-06-25 11:45 ` [RFC net-next (v2) 13/14] be2net: " Yuval Mintz
2012-06-25 11:45 ` [RFC net-next (v2) 14/14] ixgbevf: " Yuval Mintz
2012-06-25 15:45 ` Alexander Duyck [this message]
2012-06-25 15:53 ` Eilon Greenstein
2012-06-25 16:33 ` Alexander Duyck
2012-06-25 18:28 ` Eilon Greenstein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE88794.9090704@intel.com \
--to=alexander.h.duyck@intel.com \
--cc=davem@davemloft.net \
--cc=eilong@broadcom.com \
--cc=gregory.v.rose@intel.com \
--cc=jeffrey.t.kirsher@intel.com \
--cc=netdev@vger.kernel.org \
--cc=yuvalmin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).