From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Duyck Subject: Re: New commands to configure IOV features Date: Tue, 26 Jun 2012 09:13:42 -0700 Message-ID: <4FE9DFB6.5020205@intel.com> References: <4FA7AF62.8000405@broadcom.com> <20120507081634.000003f8.gregory.v.rose@intel.com> <4FE9A963.7020602@broadcom.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Ben Hutchings , Greg Rose , "netdev@vger.kernel.org" To: Yuval Mintz Return-path: Received: from mga03.intel.com ([143.182.124.21]:37025 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757866Ab2FZQNn (ORCPT ); Tue, 26 Jun 2012 12:13:43 -0400 In-Reply-To: <4FE9A963.7020602@broadcom.com> Sender: netdev-owner@vger.kernel.org List-ID: On 06/26/2012 05:21 AM, Yuval Mintz wrote: > On 05/07/2012 06:16 PM, Greg Rose wrote: > >> On Mon, 7 May 2012 14:17:54 +0300 >> Yuval Mintz wrote: >> >>> I've tried to figure out if there was a standard interface >>> (ethtool/iproute) through which a user could configure the number >>> of vfs in his system. >>> >>> I've seen the RFC suggested in >>> http://markmail.org/thread/qblfcv7zbxsxp7q6, and >>> http://markmail.org/thread/fw54dcppmxuxoe6n, but failed to see any >>> later references to it (commits or further discussion on this topic). >>> >>> How exactly are things standing with these RFCs? Were they abandoned? >> The only way to configure the number of VFs continues to be through the >> max_vfs module parameter. I've got a patch to do it through ethtool >> sitting on the back burner but due to other requirements of my day job >> I've not been able to work on it since last fall. >> >> - Greg > > Hi Ben, > > If I want to pick the RFCs and add support for configuring the number of > VFs - do you think ethtool's the right place for such added support? > > I'm asking since as far as I can see, ethtool (today) doesn't contain any > features related to virtual functions. > > Thanks, > Yuval I think the issue is that any class of PCI device could theoretically support SR-IOV. For example there could be a storage controller out there that supports spawning VFs, and an ethtool solution wouldn't work for a device like that. Personally what I would like to see is a solution that is more focused on the PCI side of the network adapters instead of the network side when it comes to enabling VFs. Thanks, Alex