public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Arvid Brodin <Arvid.Brodin@xdin.com>
To: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Stephen Hemminger <shemminger@vyatta.com>
Cc: Javier Boticario <jboticario@gmail.com>,
	Bruno Ferreira <balferreira@googlemail.com>
Subject: HSR: How to set IF_OPER_LOWERLAYERDOWN?
Date: Tue, 26 Jun 2012 22:28:51 +0000	[thread overview]
Message-ID: <4FEA37A0.309@xdin.com> (raw)

Hi,

According to Documentation/networking/operstates.txt a network interface have an
operational state and an administrative state.

If I understand things correctly the administrative state is the desired state set by
userspace, and the operational state is the actual state which depends on things like the
administrative state, whether a carrier is present, or (for virtual interfaces lite VLAN)
whether the lower interface is available.


In the driver I'm writing (for the "HSR" redundancy protocol) a hsr (virtual) interface is
useable as long as any of its (physical) slaves are useable. I.e. the operstate of a hsr
device might be set like this:

void hsr_set_operstate()
{
	if (!is_admin_up(hsr_dev)) /* Check IFF_UP */ {
		set_operstate(hsr_dev, IF_OPER_DOWN);
		return;
	}

	if (is_operstate_up(slave1) || is_operstate_up(slave2)) /* Check IF_OPER_UP */
		set_operstate(hsr_dev, IF_OPER_UP);
	else
		set_operstate(hsr_dev, IF_OPER_LOWERLAYERDOWN);
}

However, the function set_operstate() (in net/core/rtnetlink.c) only accept transitions to
IF_OPER_UP and IF_OPER_DORMANT - other transitions are ignored. (There is a function
rfc2863_policy() (net/core/link_watch.c) that may return IF_OPER_LOWERLAYERDOWN iff
(!netif_carrier_ok(dev) && (dev->ifindex != dev->iflink)), but I don't know what that means.)

So how do I signal my interface as being IF_OPER_LOWERLAYERDOWN?


In another, related matter, I'm wondering if I should set the carrier state of my virtual
interface so that it shows netif_carrier_ok() when it is possible to get the interface to
IF_OPER_UP:

void hsr_set_carrier()
{
	if (is_operstate_up(slave1) || is_operstate_up(slave2))
		netif_carrier_on(hsr_dev);
	else
		netif_carrier_off(hsr_dev);
}


Thanks,
-- 
Arvid Brodin | Consultant (Linux)
XDIN AB | Jan Stenbecks Torg 17 | SE-164 40 Kista | Sweden | xdin.com

             reply	other threads:[~2012-06-26 22:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-26 22:28 Arvid Brodin [this message]
2012-06-26 22:33 ` HSR: How to set IF_OPER_LOWERLAYERDOWN? Stephen Hemminger
2012-06-27  1:42   ` Arvid Brodin
2012-06-27 15:40     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FEA37A0.309@xdin.com \
    --to=arvid.brodin@xdin.com \
    --cc=balferreira@googlemail.com \
    --cc=jboticario@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=shemminger@vyatta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox