From: Hui Wang <jason77.wang@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Shawn Guo <shawn.guo@linaro.org>, <davem@davemloft.net>,
<netdev@vger.kernel.org>, <linux-can@vger.kernel.org>,
Hui Wang <jason77.wang@gmail.com>
Subject: Re: [PATCH] can: flexcan: use be32_to_cpup to handle the value of dt entry
Date: Thu, 28 Jun 2012 09:54:12 +0800 [thread overview]
Message-ID: <4FEBB944.1060701@gmail.com> (raw)
In-Reply-To: <4FEAEFC1.4060104@pengutronix.de>
Marc Kleine-Budde wrote:
> On 06/27/2012 01:26 PM, Shawn Guo wrote:
>
>> On 27 June 2012 17:27, Marc Kleine-Budde <mkl@pengutronix.de> wrote:
>>
>>> From: Hui Wang <jason77.wang@gmail.com>
>>>
>>> The freescale arm i.MX series platform can support this driver, and
>>> usually the arm cpu works in the little endian mode by default, while
>>> device tree entry value is stored in big endian format, we should use
>>> be32_to_cpup() to handle them, after modification, it can work well
>>> both on the le cpu and be cpu.
>>>
>>>
>> I'm wondering if you want to just use of_property_read_u32() to make
>> it a little bit easier.
>>
>
> Even better. Hui can you send a updated patch.
>
OK.
Regards,
Hui.
> Marc
>
>
next prev parent reply other threads:[~2012-06-28 1:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-27 9:27 pull-request: can 2012-06-27 Marc Kleine-Budde
2012-06-27 9:27 ` [PATCH] can: flexcan: use be32_to_cpup to handle the value of dt entry Marc Kleine-Budde
2012-06-27 11:26 ` Shawn Guo
2012-06-27 11:34 ` Marc Kleine-Budde
2012-06-28 1:54 ` Hui Wang [this message]
2012-06-27 22:28 ` pull-request: can 2012-06-27 David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FEBB944.1060701@gmail.com \
--to=jason77.wang@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-can@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=shawn.guo@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).