netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] netdev: driver: ethernet: add sysfs interface for ti cpsw
       [not found] <1341345086-25093-1-git-send-email-s-paulraj@ti.com>
@ 2012-07-03 23:16 ` David Miller
  2012-07-03 23:38   ` John Fastabend
  0 siblings, 1 reply; 2+ messages in thread
From: David Miller @ 2012-07-03 23:16 UTC (permalink / raw)
  To: s-paulraj; +Cc: cyril, mugunthanvnm, netdev

From: <s-paulraj@ti.com>
Date: Tue, 3 Jul 2012 15:51:26 -0400

> From: Sandeep Paulraj <s-paulraj@ti.com>
> 
> This patch adds sysfs entries for address lookup engine entries and
> control for the ALE(address lookup engine) found in TI SOC's.
> 
> 
> Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>

You may not create private, driver specific, unique interfaces to
configure your hardware.

You must use existing facilities such as ethtool to add such things.
If the existing facilities are insufficient, you must extend them to
meet your (and potentially other's) needs.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] netdev: driver: ethernet: add sysfs interface for ti cpsw
  2012-07-03 23:16 ` [PATCH] netdev: driver: ethernet: add sysfs interface for ti cpsw David Miller
@ 2012-07-03 23:38   ` John Fastabend
  0 siblings, 0 replies; 2+ messages in thread
From: John Fastabend @ 2012-07-03 23:38 UTC (permalink / raw)
  To: s-paulraj; +Cc: David Miller, cyril, mugunthanvnm, netdev

On 7/3/2012 4:16 PM, David Miller wrote:
> From: <s-paulraj@ti.com>
> Date: Tue, 3 Jul 2012 15:51:26 -0400
>
>> From: Sandeep Paulraj <s-paulraj@ti.com>
>>
>> This patch adds sysfs entries for address lookup engine entries and
>> control for the ALE(address lookup engine) found in TI SOC's.
>>
>>
>> Signed-off-by: Sandeep Paulraj <s-paulraj@ti.com>
>
> You may not create private, driver specific, unique interfaces to
> configure your hardware.
>
> You must use existing facilities such as ethtool to add such things.
> If the existing facilities are insufficient, you must extend them to
> meet your (and potentially other's) needs.
> --

I can't seem to dig up the original email perhaps my server is slow
today but did you consider using these hooks ndo_fdb_add(),
ndo_fdb_del(), and ndo_fdb_dump() added recently.

These are for adding/deleting and dumping the address forwarding
databases. Failing that would something like this RFC with another
attribute work,

http://comments.gmane.org/gmane.linux.network/232104

Thanks,
John

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2012-07-03 23:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1341345086-25093-1-git-send-email-s-paulraj@ti.com>
2012-07-03 23:16 ` [PATCH] netdev: driver: ethernet: add sysfs interface for ti cpsw David Miller
2012-07-03 23:38   ` John Fastabend

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).