netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
To: "Erdt, Ralph" <ralph.erdt@fkie.fraunhofer.de>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Eric Dumazet <eric.dumazet@gmail.com>,
	Rick Jones <rick.jones2@hp.com>
Subject: Re: RFC: (now non Base64) replace packets already in queue
Date: Wed, 04 Jul 2012 22:32:51 +0200	[thread overview]
Message-ID: <4FF4A873.1000001@gmail.com> (raw)
In-Reply-To: <FB112703C4930F4ABEBB5B763F96491139379ECF@MAILSERV2A.lorien.fkie.fgan.de>

Le 03/07/2012 12:02, Erdt, Ralph a écrit :
> My question is: Should I do the work to create and release a kernel patch and make
> it perfect over the time, or is this just our internal code, which I can leave at
> the current state? I know our module won't be used widely (too special), but I'm
> sure, there are a few people out there, which would be thankful for this.

I suggest you try and send a properly formated patch with your code, so that people here can have a 
look at it and evaluate the interest of integrating it into main line kernel.

That being said, I really think you should try to manage a userspace queue, in particular if you 
already have most of the job done in userspace using a tun/tap. I don't know the details of the 
special device you work with, but if you manage both side of the link, you can add many nice 
features into userspace to enhance the speed/quality :

- Compression (including very clever one if you know the meaning of the data you are transmitting).
- Packet numbering, to allow the remote side to ACK packet, the same way TCP does.
- Early ACK on TCP, if you get an ACK from the other side of your link and you assure that this link 
is the worst part of the path. This may help TCP to work on this low speed/high RTT link.

And I really see your packet replacement system as one of those nice features and cannot imagine a 
good reason not to put it in userspace.

	Nicolas.

  reply	other threads:[~2012-07-04 20:31 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-06-28 13:18 RFC: replace packets already in queue Erdt, Ralph
2012-06-28 16:24 ` Rick Jones
2012-06-29  8:46   ` AW: " Erdt, Ralph
2012-06-29  9:06     ` Eric Dumazet
2012-07-02  7:02       ` Erdt, Ralph
2012-07-02  7:31         ` Eric Dumazet
2012-07-02  8:38           ` AW: " Erdt, Ralph
2012-07-02 17:25             ` Rick Jones
2012-07-02 20:32             ` Nicolas de Pesloüan
2012-07-02 21:56               ` Eric Dumazet
2012-07-03  7:29                 ` AW: " Erdt, Ralph
2012-07-03 10:02                   ` RFC: (now non Base64) " Erdt, Ralph
2012-07-04 20:32                     ` Nicolas de Pesloüan [this message]
2012-07-18 14:50                       ` AW: " Erdt, Ralph

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FF4A873.1000001@gmail.com \
    --to=nicolas.2p.debian@gmail.com \
    --cc=eric.dumazet@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=ralph.erdt@fkie.fraunhofer.de \
    --cc=rick.jones2@hp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).