From: Or Gerlitz <ogerlitz@mellanox.com>
To: David Miller <davem@davemloft.net>, <eric.dumazet@gmail.com>
Cc: <roland@kernel.org>, <netdev@vger.kernel.org>, <ali@mellanox.com>,
<sean.hefty@intel.com>, <erezsh@mellanox.co.il>
Subject: Re: [PATCH net-next 3/9] IB/ipoib: Add support for acting as VIF
Date: Wed, 11 Jul 2012 12:59:41 +0300 [thread overview]
Message-ID: <4FFD4E8D.7040608@mellanox.com> (raw)
In-Reply-To: <20120711.011912.2063611962030549397.davem@davemloft.net>
On 7/11/2012 11:19 AM, David Miller wrote:
> handle_ing() goes into the packet scheduler and qdisc layer, the qdisc
> layer uses skb->cb[] via struct qdisc_skb_cb
Oh, I knew that the qdisc layer touches skb->cb[] but thought it only
happens on the TX flow...
Here, the flow Eric pointed on relates to skb which was received by
IPoIB and is soon going
to be consumed by the eIPoIB driver once the rx handler planted by it is
executed on the skb.
So even in this "simple" flow we can't assume that qdisc will not
interfere (why)?
if indeed this is case - I understand that we still can deploy the
practice used by
ipoib_hard_header which uses struct ipoib_cb, or in other words we can
use 20 out
of the 48 bytes of the cb, starting from offset of 28 bytes, correct?
Or.
next prev parent reply other threads:[~2012-07-11 10:02 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-10 12:16 [PATCH net-next 0/9] Add Ethernet IPoIB driver Or Gerlitz
2012-07-10 12:16 ` [PATCH net-next 1/9] IB/ipoib: Add support for clones / multiple childs on the same partition Or Gerlitz
2012-07-10 12:16 ` [PATCH net-next 2/9] include/linux: Add private flags for IPoIB interfaces Or Gerlitz
2012-07-10 12:16 ` [PATCH net-next 3/9] IB/ipoib: Add support for acting as VIF Or Gerlitz
2012-07-10 12:26 ` Eric Dumazet
2012-07-11 8:05 ` Or Gerlitz
2012-07-11 8:19 ` David Miller
2012-07-11 9:59 ` Or Gerlitz [this message]
2012-07-11 10:06 ` David Miller
2012-07-11 10:27 ` Eric Dumazet
2012-07-11 11:46 ` Or Gerlitz
2012-07-10 12:16 ` [PATCH net-next 4/9] net/eipoib: Add private header file Or Gerlitz
2012-07-10 12:16 ` [PATCH net-next 5/9] net/eipoib: Add ethtool file support Or Gerlitz
2012-07-10 17:48 ` Ben Hutchings
2012-07-11 8:40 ` Or Gerlitz
2012-07-10 12:16 ` [PATCH net-next 6/9] net/eipoib: Add sysfs support Or Gerlitz
2012-07-10 12:16 ` [PATCH net-next 7/9] net/eipoib: Add main driver functionality Or Gerlitz
2012-07-10 12:16 ` [PATCH net-next 8/9] net/eipoib: Add Makefile, Kconfig and MAINTAINERS entries Or Gerlitz
2012-07-10 12:16 ` [PATCH net-next 9/9] IB/ipoib: Add support for transmission of skbs w.o dst/neighbour Or Gerlitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFD4E8D.7040608@mellanox.com \
--to=ogerlitz@mellanox.com \
--cc=ali@mellanox.com \
--cc=davem@davemloft.net \
--cc=erezsh@mellanox.co.il \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).