From: Hadar Hen Zion <hadarh@mellanox.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Hadar Hen Zion <hadarh@mellanox.co.il>,
"David S. Miller" <davem@davemloft.net>,
Or Gerlitz <ogerlitz@mellanox.com>,
Eugenia Emantayev <eugenia@mellanox.co.il>,
Yevgeny Petrilin <yevgenyp@mellanox.co.il>,
<netdev@vger.kernel.org>, <kernel-janitors@vger.kernel.org>
Subject: Re: [patch] net/mlx4: off by one in parse_trans_rule()
Date: Wed, 11 Jul 2012 17:51:50 +0300 [thread overview]
Message-ID: <4FFD9306.3000600@mellanox.com> (raw)
In-Reply-To: <20120711063336.GC11812@elgon.mountain>
On 7/11/2012 9:33 AM, Dan Carpenter wrote:
> This should be ">=" here instead of ">". MLX4_NET_TRANS_RULE_NUM is 6.
> We use "spec->id" as an array offset into the __rule_hw_sz[] and
> __sw_id_hw[] arrays which have 6 elements.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/net/ethernet/mellanox/mlx4/mcg.c b/drivers/net/ethernet/mellanox/mlx4/mcg.c
> index bc62f53..5bac0df 100644
> --- a/drivers/net/ethernet/mellanox/mlx4/mcg.c
> +++ b/drivers/net/ethernet/mellanox/mlx4/mcg.c
> @@ -773,7 +773,7 @@ static int parse_trans_rule(struct mlx4_dev *dev, struct mlx4_spec_list *spec,
> [MLX4_NET_TRANS_RULE_ID_UDP] =
> sizeof(struct mlx4_net_trans_rule_hw_tcp_udp)
> };
> - if (spec->id > MLX4_NET_TRANS_RULE_NUM) {
> + if (spec->id >= MLX4_NET_TRANS_RULE_NUM) {
> mlx4_err(dev, "Invalid network rule id. id = %d\n", spec->id);
> return -EINVAL;
> }
>
Hi Dan,
This is indeed a bug, thanks for spotting this over,
Please add:
Acked-by: Hadar Hen Zion <hadarh@mellanox.co.il>
Hadar
next prev parent reply other threads:[~2012-07-11 14:54 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-11 6:33 [patch] net/mlx4: off by one in parse_trans_rule() Dan Carpenter
2012-07-11 14:51 ` Hadar Hen Zion [this message]
2012-07-17 5:58 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FFD9306.3000600@mellanox.com \
--to=hadarh@mellanox.com \
--cc=dan.carpenter@oracle.com \
--cc=davem@davemloft.net \
--cc=eugenia@mellanox.co.il \
--cc=hadarh@mellanox.co.il \
--cc=kernel-janitors@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
--cc=yevgenyp@mellanox.co.il \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).