* [PATCH net v2] r8169: fix RTL8168H and RTL8107E rx crc error
@ 2023-03-23 14:33 ChunHao Lin
2023-03-25 2:08 ` Jakub Kicinski
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: ChunHao Lin @ 2023-03-23 14:33 UTC (permalink / raw)
To: hkallweit1; +Cc: netdev, nic_swsd, ChunHao Lin
When link speed is 10 Mbps and temperature is under -20°C, RTL8168H and
RTL8107E may have rx crc error. Disable phy 10 Mbps pll off to fix this
issue.
Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
Signed-off-by: ChunHao Lin <hau@realtek.com>
---
V1 -> V2:
- add Fixes tag
- change title and description
drivers/net/ethernet/realtek/r8169_phy_config.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/ethernet/realtek/r8169_phy_config.c b/drivers/net/ethernet/realtek/r8169_phy_config.c
index 930496cd34ed..b50f16786c24 100644
--- a/drivers/net/ethernet/realtek/r8169_phy_config.c
+++ b/drivers/net/ethernet/realtek/r8169_phy_config.c
@@ -826,6 +826,9 @@ static void rtl8168h_2_hw_phy_config(struct rtl8169_private *tp,
/* disable phy pfm mode */
phy_modify_paged(phydev, 0x0a44, 0x11, BIT(7), 0);
+ /* disable 10m pll off */
+ phy_modify_paged(phydev, 0x0a43, 0x10, BIT(0), 0);
+
rtl8168g_disable_aldps(phydev);
rtl8168g_config_eee_phy(phydev);
}
--
2.37.2
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH net v2] r8169: fix RTL8168H and RTL8107E rx crc error
2023-03-23 14:33 [PATCH net v2] r8169: fix RTL8168H and RTL8107E rx crc error ChunHao Lin
@ 2023-03-25 2:08 ` Jakub Kicinski
2023-03-25 8:49 ` Heiner Kallweit
2023-03-25 11:31 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Jakub Kicinski @ 2023-03-25 2:08 UTC (permalink / raw)
To: hkallweit1; +Cc: ChunHao Lin, netdev, nic_swsd
On Thu, 23 Mar 2023 22:33:09 +0800 ChunHao Lin wrote:
> When link speed is 10 Mbps and temperature is under -20°C, RTL8168H and
> RTL8107E may have rx crc error. Disable phy 10 Mbps pll off to fix this
> issue.
>
> Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
> Signed-off-by: ChunHao Lin <hau@realtek.com>
Hi Heiner, looks good?
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net v2] r8169: fix RTL8168H and RTL8107E rx crc error
2023-03-23 14:33 [PATCH net v2] r8169: fix RTL8168H and RTL8107E rx crc error ChunHao Lin
2023-03-25 2:08 ` Jakub Kicinski
@ 2023-03-25 8:49 ` Heiner Kallweit
2023-03-25 11:31 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: Heiner Kallweit @ 2023-03-25 8:49 UTC (permalink / raw)
To: ChunHao Lin, Jakub Kicinski; +Cc: netdev, nic_swsd
On 23.03.2023 15:33, ChunHao Lin wrote:
> When link speed is 10 Mbps and temperature is under -20°C, RTL8168H and
> RTL8107E may have rx crc error. Disable phy 10 Mbps pll off to fix this
> issue.
>
> Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
> Signed-off-by: ChunHao Lin <hau@realtek.com>
> ---
> V1 -> V2:
> - add Fixes tag
> - change title and description
>
Reviewed-by: Heiner Kallweit <hkallweit1@gmail.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH net v2] r8169: fix RTL8168H and RTL8107E rx crc error
2023-03-23 14:33 [PATCH net v2] r8169: fix RTL8168H and RTL8107E rx crc error ChunHao Lin
2023-03-25 2:08 ` Jakub Kicinski
2023-03-25 8:49 ` Heiner Kallweit
@ 2023-03-25 11:31 ` patchwork-bot+netdevbpf
2 siblings, 0 replies; 4+ messages in thread
From: patchwork-bot+netdevbpf @ 2023-03-25 11:31 UTC (permalink / raw)
To: ChunHao Lin; +Cc: hkallweit1, netdev, nic_swsd
Hello:
This patch was applied to netdev/net.git (main)
by David S. Miller <davem@davemloft.net>:
On Thu, 23 Mar 2023 22:33:09 +0800 you wrote:
> When link speed is 10 Mbps and temperature is under -20°C, RTL8168H and
> RTL8107E may have rx crc error. Disable phy 10 Mbps pll off to fix this
> issue.
>
> Fixes: 6e1d0b898818 ("r8169:add support for RTL8168H and RTL8107E")
> Signed-off-by: ChunHao Lin <hau@realtek.com>
>
> [...]
Here is the summary with links:
- [net,v2] r8169: fix RTL8168H and RTL8107E rx crc error
https://git.kernel.org/netdev/net/c/33189f0a94b9
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-03-25 11:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-23 14:33 [PATCH net v2] r8169: fix RTL8168H and RTL8107E rx crc error ChunHao Lin
2023-03-25 2:08 ` Jakub Kicinski
2023-03-25 8:49 ` Heiner Kallweit
2023-03-25 11:31 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).