From: Yonghong Song <yhs@fb.com>
To: John Fastabend <john.fastabend@gmail.com>, <ast@kernel.org>,
<daniel@iogearbox.net>
Cc: <lmb@cloudflare.com>, <bpf@vger.kernel.org>,
<jakub@cloudflare.com>, <netdev@vger.kernel.org>
Subject: Re: [bpf-next PATCH v2 2/5] bpf: extend bpf_base_func_proto helpers with probe_* and *current_task*
Date: Sun, 17 May 2020 22:13:52 -0700 [thread overview]
Message-ID: <4a309ec7-4885-5634-4b2e-3c775890c7d7@fb.com> (raw)
In-Reply-To: <158958037715.12532.12473092995203096801.stgit@john-Precision-5820-Tower>
On 5/15/20 3:06 PM, John Fastabend wrote:
> Often it is useful when applying policy to know something about the
> task. If the administrator has CAP_SYS_ADMIN rights then they can
> use kprobe + networking hook and link the two programs together to
> accomplish this. However, this is a bit clunky and also means we have
> to call both the network program and kprobe program when we could just
> use a single program and avoid passing metadata through sk_msg/skb->cb,
> socket, maps, etc.
>
> To accomplish this add probe_* helpers to bpf_base_func_proto programs
> guarded by a perfmon_capable() check. New supported helpers are the
> following,
>
> BPF_FUNC_get_current_task
> BPF_FUNC_current_task_under_cgroup
> BPF_FUNC_probe_read_user
> BPF_FUNC_probe_read_kernel
> BPF_FUNC_probe_read_user_str
> BPF_FUNC_probe_read_kernel_str
>
> Signed-off-by: John Fastabend <john.fastabend@gmail.com>
Acked-by: Yonghong Song <yhs@fb.com>
next prev parent reply other threads:[~2020-05-18 5:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-15 22:05 [bpf-next PATCH v2 0/5] bpf: Add sk_msg and networking helpers John Fastabend
2020-05-15 22:05 ` [bpf-next PATCH v2 1/5] bpf: sk_msg add some generic helpers that may be useful from sk_msg John Fastabend
2020-05-15 22:06 ` [bpf-next PATCH v2 2/5] bpf: extend bpf_base_func_proto helpers with probe_* and *current_task* John Fastabend
2020-05-18 5:13 ` Yonghong Song [this message]
2020-05-15 22:06 ` [bpf-next PATCH v2 3/5] bpf: sk_msg add get socket storage helpers John Fastabend
2020-05-18 5:24 ` Yonghong Song
2020-05-15 22:06 ` [bpf-next PATCH v2 4/5] bpf: selftests, add sk_msg helpers load and attach test John Fastabend
2020-05-15 22:07 ` [bpf-next PATCH v2 5/5] bpf: selftests, test probe_* helpers from SCHED_CLS John Fastabend
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a309ec7-4885-5634-4b2e-3c775890c7d7@fb.com \
--to=yhs@fb.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=jakub@cloudflare.com \
--cc=john.fastabend@gmail.com \
--cc=lmb@cloudflare.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox