From: Andrew Lunn <andrew@lunn.ch>
To: "Bjørn Mork" <bjorn@mork.no>
Cc: netdev@vger.kernel.org, "Lucien.Jheng" <lucienzx159@gmail.com>,
Daniel Golle <daniel@makrotopia.org>,
Vladimir Oltean <vladimir.oltean@nxp.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/3] net: phy: air_en8811h: add Airoha AN8811HB support
Date: Sat, 24 Jan 2026 00:01:29 +0100 [thread overview]
Message-ID: <4a3430cc-5a9a-414e-9dbf-cbc34c8fd019@lunn.ch> (raw)
In-Reply-To: <20260123075817.1162068-3-bjorn@mork.no>
> +#define AN8811HB_GPIO_OUTPUT 0x5cf8b8
> +#define AN8811HB_GPIO_OUTPUT_345 (BIT(3) | BIT(4) | BIT(5))
> + /* Configure led gpio pins as output */
> + ret = air_buckpbus_reg_modify(phydev, AN8811HB_GPIO_OUTPUT,
> + AN8811HB_GPIO_OUTPUT_345,
> + AN8811HB_GPIO_OUTPUT_345);
The code/comment probably does not describe what is actually happening
here. My _guess_ is you are setting a pinmux, disconnecting the pins
from the GPIO controller and connecting them to the LED controller.
I assume there is no open data sheet for this device?
Andrew
next prev parent reply other threads:[~2026-01-23 23:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-23 7:58 [PATCH net-next v2 0/3] Airoha AN8811HB 2.5 Gbps phy support Bjørn Mork
2026-01-23 7:58 ` [PATCH net-next v2 1/3] net: phy: air_en8811h: factor out shareable code Bjørn Mork
2026-01-23 22:50 ` Andrew Lunn
2026-01-24 16:55 ` Bjørn Mork
2026-01-24 18:38 ` Andrew Lunn
2026-01-25 10:51 ` Bjørn Mork
2026-01-25 16:23 ` Andrew Lunn
2026-01-23 7:58 ` [PATCH net-next v2 2/3] net: phy: air_en8811h: add Airoha AN8811HB support Bjørn Mork
2026-01-23 23:01 ` Andrew Lunn [this message]
2026-01-24 16:53 ` Bjørn Mork
2026-01-24 18:33 ` Andrew Lunn
2026-01-25 11:07 ` Bjørn Mork
2026-01-23 7:58 ` [PATCH net-next v2 3/3] net: phy: air_en8811h: Add clk provider for an8811hb Bjørn Mork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a3430cc-5a9a-414e-9dbf-cbc34c8fd019@lunn.ch \
--to=andrew@lunn.ch \
--cc=bjorn@mork.no \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=lucienzx159@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox