From: Paolo Abeni <pabeni@redhat.com>
To: Michael Chan <michael.chan@broadcom.com>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, kuba@kernel.org,
andrew+netdev@lunn.ch, pavan.chebbi@broadcom.com,
andrew.gospodarek@broadcom.com
Subject: Re: [PATCH net-next v4 15/15] bnxt_en: Add kTLS retransmission support
Date: Thu, 2 Jul 2026 09:55:13 +0200 [thread overview]
Message-ID: <4a4fd25c-9df8-4de3-9229-cd4d5f2b7ef6@redhat.com> (raw)
In-Reply-To: <20260629184921.3496727-16-michael.chan@broadcom.com>
On 6/29/26 8:49 PM, Michael Chan wrote:
> int bnxt_ktls_alloc_tx_ring_stats(struct bnxt *bp, struct bnxt_tx_ring_info *txr)
> diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_ktls.h b/drivers/net/ethernet/broadcom/bnxt/bnxt_ktls.h
> index 1c935e0d413d..40b94bbf5a38 100644
> --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_ktls.h
> +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_ktls.h
> @@ -43,6 +43,8 @@ struct bnxt_ktls_offload_ctx_tx {
> u32 next_tcp_seq_no;/* staged tcp seq no */
> u32 kid;
> u32 pending_bytes; /* staged payload bytes */
> + u32 pending_fwd:1;
> + u32 pending_ooo:1;
Minor nit: AFAICS the above field are touched in fastpath. Using a
`bool` type will likely yield better code.
/P
prev parent reply other threads:[~2026-07-02 7:55 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-29 18:49 [PATCH net-next v4 00/15] bnxt_en: Add kTLS TX offload support Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 01/15] bnxt_en: Add Midpath channel information Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 02/15] bnxt_en: Account for the MPC TX and CP rings Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 03/15] bnxt_en: Set default MPC ring count Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 04/15] bnxt_en: Rename xdp_tx_lock to tx_lock Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 05/15] bnxt_en: Allocate and free MPC software structures Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 06/15] bnxt_en: Allocate and free MPC channels from firmware Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 07/15] bnxt_en: Allocate crypto structure and backing store Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 08/15] bnxt_en: Reserve crypto RX and TX key contexts on a PF Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 09/15] bnxt_en: Add infrastructure for crypto key context IDs Michael Chan
2026-07-02 7:53 ` Paolo Abeni
2026-06-29 18:49 ` [PATCH net-next v4 10/15] bnxt_en: Add MPC transmit and completion functions Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 11/15] bnxt_en: Add crypto MPC transmit/completion infrastructure Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 12/15] bnxt_en: Support kTLS TX offload by implementing .tls_dev_add/del() Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 13/15] bnxt_en: Implement kTLS TX normal path Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 14/15] bnxt_en: Add support for inline transmit BDs Michael Chan
2026-06-29 18:49 ` [PATCH net-next v4 15/15] bnxt_en: Add kTLS retransmission support Michael Chan
2026-07-02 7:55 ` Paolo Abeni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a4fd25c-9df8-4de3-9229-cd4d5f2b7ef6@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pavan.chebbi@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox