From: luoxuanqiang <xuanqiang.luo@linux.dev>
To: Sang-Heon Jeon <ekffu200098@gmail.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
Veerasenareddy Burru <vburru@marvell.com>,
Sathesh Edara <sedara@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net-next] octeon_ep: remove redundant memset in octep_setup_pfvf_mbox()
Date: Tue, 1 Sep 2026 21:04:40 +0800 [thread overview]
Message-ID: <4a664246-eaf9-47ad-98a0-10a0fccce572@linux.dev> (raw)
In-Reply-To: <20260901110913.977745-1-ekffu200098@gmail.com>
在 2026/9/1 19:09, Sang-Heon Jeon 写道:
> vzalloc() returns zeroed memory, so the memset after the allocation is
> redundant.
>
> No functional change.
>
> Signed-off-by: Sang-Heon Jeon <ekffu200098@gmail.com>
Reviewed-by: Xuanqiang Luo<luoxuanqiang@kylinos.cn> Thanks,
Xuanqiang
> ---
> drivers/net/ethernet/marvell/octeon_ep/octep_pfvf_mbox.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/marvell/octeon_ep/octep_pfvf_mbox.c b/drivers/net/ethernet/marvell/octeon_ep/octep_pfvf_mbox.c
> index 0867fab61b19..e4175d5bdb3b 100644
> --- a/drivers/net/ethernet/marvell/octeon_ep/octep_pfvf_mbox.c
> +++ b/drivers/net/ethernet/marvell/octeon_ep/octep_pfvf_mbox.c
> @@ -274,7 +274,6 @@ int octep_setup_pfvf_mbox(struct octep_device *oct)
> if (!oct->mbox[ring])
> goto free_mbox;
>
> - memset(oct->mbox[ring], 0, sizeof(struct octep_mbox));
> memset(&oct->vf_info[i], 0, sizeof(struct octep_pfvf_info));
> mutex_init(&oct->mbox[ring]->lock);
> INIT_WORK(&oct->mbox[ring]->wk.work, octep_pfvf_mbox_work);
next prev parent reply other threads:[~2026-09-01 13:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-01 11:09 [PATCH net-next] octeon_ep: remove redundant memset in octep_setup_pfvf_mbox() Sang-Heon Jeon
2026-09-01 13:04 ` luoxuanqiang [this message]
2026-09-03 11:00 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4a664246-eaf9-47ad-98a0-10a0fccce572@linux.dev \
--to=xuanqiang.luo@linux.dev \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=ekffu200098@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sedara@marvell.com \
--cc=vburru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox