From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=0.5 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4CC0C1975A for ; Sun, 22 Mar 2020 21:43:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 95CC92072D for ; Sun, 22 Mar 2020 21:43:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="CEsmlKBO" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726875AbgCVVnV (ORCPT ); Sun, 22 Mar 2020 17:43:21 -0400 Received: from mail-il1-f194.google.com ([209.85.166.194]:43225 "EHLO mail-il1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726756AbgCVVnV (ORCPT ); Sun, 22 Mar 2020 17:43:21 -0400 Received: by mail-il1-f194.google.com with SMTP id g15so2178601ilj.10 for ; Sun, 22 Mar 2020 14:43:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=1CHo0x7Wfa4qJuuhN1bUA7KIQ3CQGNq7ky+pcnD/4Uo=; b=CEsmlKBOQmY99DNo8MbwuwxfPrxPANZ5DyeJnrNTY6rqzRcRltn7VGm2LybgyxP9vo G1EoYAP1hqSmjQ7QDXoXiN/BomPjTgSpEFzTJy0NZ+bpPhDWsIpBN9Gfv94kct1k2cL/ LiTBjvD1hrYoec1zGrPE1uyeibj2WeWxfm6czZy6wCKkUYQuqx/7CMNVswBHq30SFoSn Hr3bU+34lJGLF8XS5oWwX7YLmaGBtbmoeSVslC2XrB/FDZZjOpN2kBk0mjZ5Kx6O62W5 DNIiVD4d4sVQODAFrggBupgdM076o1LaOj6YzC3wGJHMNXorzuDrGHEoniG9LSqDA03X xLaA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=1CHo0x7Wfa4qJuuhN1bUA7KIQ3CQGNq7ky+pcnD/4Uo=; b=VhOnLrrgq6iJ3vt0jUMc5yiWBnrxUQWSSIrNp3dDP1SecOUy5jzyIMVP2PtXM0Uxb4 cJ8v9RqPRNnpL8/lo6sISVy3O5id4ulGz50p9tOfYYsHU2y2OkkpNL3QIsT2PJRw3OPp CSV7evF13Lw2a/byTDiSo+PMo6DODy+XVM0AjRH5vio7IW1A2Zok9UfNCkdhJ1bOR12w zfzVFso9G78gZyvbXBBsJ4OAkBJTQGhgazYd2eQE/jbltCcgPRfvBQp3zQFpTaDtty/T OwCJH3opOEHlRI6fxyEgdaRPdcWJ2LxCT8Oc6y6WE+S9oNrMKT6gAn4bM/obH9CgsqX3 RCuQ== X-Gm-Message-State: ANhLgQ16h+LGyMLLp+biUw11Mj5zHgrTTZ8xqstcXn8q1LjrzmxZ0SwS Y5aBooT/D3OwjImHerYhQ5w= X-Google-Smtp-Source: ADFU+vs7h2tT00HbfKqb22pmXHjuWtkDwjK34tUHw82MfCDEz2XVI8KtTBcTRYnEgbCtPl7YUhd09Q== X-Received: by 2002:a92:c841:: with SMTP id b1mr18140904ilq.116.1584913400625; Sun, 22 Mar 2020 14:43:20 -0700 (PDT) Received: from ?IPv6:2601:282:803:7700:1523:c157:28b9:614d? ([2601:282:803:7700:1523:c157:28b9:614d]) by smtp.googlemail.com with ESMTPSA id n26sm3784794ioo.9.2020.03.22.14.43.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 22 Mar 2020 14:43:19 -0700 (PDT) Subject: Re: [PATCH iproute2-next 2/2] tc: q_red: Support 'nodrop' flag To: Petr Machata , netdev@vger.kernel.org Cc: David Ahern References: From: David Ahern Message-ID: <4ace5bb3-df27-44eb-dee7-6469deb0ec1b@gmail.com> Date: Sun, 22 Mar 2020 15:43:18 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/18/20 6:18 AM, Petr Machata wrote: > @@ -154,6 +161,7 @@ static int red_parse_opt(struct qdisc_util *qu, int argc, char **argv, > addattr_l(n, 1024, TCA_RED_STAB, sbuf, 256); > max_P = probability * pow(2, 32); > addattr_l(n, 1024, TCA_RED_MAX_P, &max_P, sizeof(max_P)); > + addattr_l(n, 1024, TCA_RED_FLAGS, &flags_bf, sizeof(flags_bf)); the attr is a bitfield32 here ... > addattr_nest_end(n, tail); > return 0; > } > @@ -183,6 +191,10 @@ static int red_print_opt(struct qdisc_util *qu, FILE *f, struct rtattr *opt) > RTA_PAYLOAD(tb[TCA_RED_MAX_P]) >= sizeof(__u32)) > max_P = rta_getattr_u32(tb[TCA_RED_MAX_P]); > > + if (tb[TCA_RED_FLAGS] && > + RTA_PAYLOAD(tb[TCA_RED_FLAGS]) >= sizeof(__u32)) > + qopt->flags = rta_getattr_u32(tb[TCA_RED_FLAGS]); > + but a u32 here. These should be consistent.