From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1143AC282CF for ; Mon, 28 Jan 2019 20:49:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D209E214DA for ; Mon, 28 Jan 2019 20:49:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="N6eL83xN" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726993AbfA1Utu (ORCPT ); Mon, 28 Jan 2019 15:49:50 -0500 Received: from mail-io1-f67.google.com ([209.85.166.67]:45012 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726805AbfA1Utu (ORCPT ); Mon, 28 Jan 2019 15:49:50 -0500 Received: by mail-io1-f67.google.com with SMTP id r200so14678647iod.11 for ; Mon, 28 Jan 2019 12:49:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=fcGXcqOHyo1FhhAyMzyXFfzciwvfIf6cD+LjmtGy8eo=; b=N6eL83xNtAL2MQDhCXkheewEWnZVEPWMi/lUcMzUKJSihL0zzL8cNcw2XrtpnFmXHg oGZVaDkvSc6foZ5lWAEcdY+yMXLkuPF177aMNXd9Y3zVP7rhAedWfKYBd3nDbW5D4+6W 6Ife9Hw1dAh6qBRUDY2wNyQiQLuEDSBDwZCt1HCyQkOqrCfTGyV7HkNCPYzy8Gr6Pckq /qZ8t/l8n85TX//Edrv1EwTtLxrPze575OntSqC4JYA7fc5+WPKvvqEsAWzicbhkrydd dawkFRMv6tL9kMTGsAc2ap5UEH5PVic5BZSXTXaDWZUCbCb+efUPffv9o8Ry3bCRfCn7 1WPA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fcGXcqOHyo1FhhAyMzyXFfzciwvfIf6cD+LjmtGy8eo=; b=igBJOD2zQXT4QRtKYMDiIakn8U0TDQiB8xQVhMR7p2asl0+WyytEtOerk129HGH0Sg d0Iv+AWxgMyElRuBOaKrSuedwHOGzjkmG2gUkHQMLFzbR04riogY9GJt6Y6f+0Dyv+LH neJ3X4sN28cu5v+11IW+HzPDpOATgaFaECYbPPxq1aX+uLg3NSV0fnXIRrfVq4sw9/To AXyWO5N+OiE4P70Ok12AMec0PhzEQCR6ZgKSYYyvPh8uGOMFGDbCcWT/D6k1THaGS1Za XuOgNLLYLeAVEl6ga02pO8Vc2wCP2twPyZ7+R2FIuhqqe0DRlkQRr3PqCF2fmJ11eW82 EHYA== X-Gm-Message-State: AHQUAuY9jbhibQ3inerWK/FfAlksE+W7lkDGPx0yenas60aj7k2Yf27L Gys5+v3QdARxW98s8VOdlZc= X-Google-Smtp-Source: AHgI3Iaj37dXZOFKiFdvqfuwUWfRpyjzAEf1N3NTU+fiC8xnNmjEBVvNOAZL5IHg5JEZINLJBQhRSA== X-Received: by 2002:a6b:39c6:: with SMTP id g189mr1889240ioa.255.1548708589232; Mon, 28 Jan 2019 12:49:49 -0800 (PST) Received: from [192.168.86.250] ([184.63.162.180]) by smtp.gmail.com with ESMTPSA id o16sm247244ito.19.2019.01.28.12.49.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 28 Jan 2019 12:49:48 -0800 (PST) Subject: Re: [PATCH bpf-next v4 1/7] libbpf: Add a helper for retrieving a map fd for a given name To: Maciej Fijalkowski , daniel@iogearbox.net, ast@kernel.org Cc: netdev@vger.kernel.org, jakub.kicinski@netronome.com, brouer@redhat.com References: <20190128191613.11705-1-maciejromanfijalkowski@gmail.com> <20190128191613.11705-2-maciejromanfijalkowski@gmail.com> From: John Fastabend Message-ID: <4ad3afa8-f2c3-50a9-d2a0-e8db683236bb@gmail.com> Date: Mon, 28 Jan 2019 12:49:35 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190128191613.11705-2-maciejromanfijalkowski@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/28/19 11:16 AM, Maciej Fijalkowski wrote: > From: Maciej Fijalkowski > > XDP samples are mostly cooperating with eBPF maps through their file > descriptors. In case of a eBPF program that contains multiple maps it > might be tiresome to iterate through them and call bpf_map__fd for each > one. Add a helper mostly based on bpf_object__find_map_by_name, but > instead of returning the struct bpf_map pointer, return map fd. > > Suggested-by: Jakub Kicinski > Signed-off-by: Maciej Fijalkowski > Reviewed-by: Jakub Kicinski > --- I've been carrying something similar around for awhile as well. Acked-by: John Fastabend