Netdev List
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: James Hilliard <james.hilliard1@gmail.com>
Cc: "Heiner Kallweit" <hkallweit1@gmail.com>,
	"Russell King" <linux@armlinux.org.uk>,
	"David S. Miller" <davem@davemloft.net>,
	"Eric Dumazet" <edumazet@google.com>,
	"Jakub Kicinski" <kuba@kernel.org>,
	"Paolo Abeni" <pabeni@redhat.com>,
	"Florian Fainelli" <f.fainelli@gmail.com>,
	"Richard Cochran" <richardcochran@gmail.com>,
	"Rob Herring" <robh@kernel.org>,
	"Saravana Kannan" <saravanak@kernel.org>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Jonas Gorski" <jonas.gorski@gmail.com>,
	"Vladimir Oltean" <olteanv@gmail.com>,
	"Ciprian Regus" <ciprian.regus@analog.com>,
	"Andreas Larsson" <andreas@gaisler.com>,
	"Mark Einon" <mark.einon@gmail.com>,
	"Iyappan Subramanian" <iyappan@os.amperecomputing.com>,
	"Keyur Chudgar" <keyur@os.amperecomputing.com>,
	"Michael Chan" <michael.chan@broadcom.com>,
	"Rafał Miłecki" <rafal@milecki.pl>,
	"Broadcom internal kernel review list"
	<bcm-kernel-feedback-list@broadcom.com>,
	"Doug Berger" <opendmb@gmail.com>,
	"Pavan Chebbi" <pavan.chebbi@broadcom.com>,
	"Théo Lebrun" <theo.lebrun@bootlin.com>,
	"Conor Dooley" <conor.dooley@microchip.com>,
	"Wei Fang" <wei.fang@nxp.com>, "Frank Li" <frank.li@nxp.com>,
	"Shenwei Wang" <shenwei.wang@nxp.com>,
	"Jijie Shao" <shaojijie@huawei.com>,
	"Jian Shen" <shenjian15@huawei.com>,
	"Bryan Whitehead" <bryan.whitehead@microchip.com>,
	UNGLinuxDriver@microchip.com, "Vladimir Zapolskiy" <vz@mleia.com>,
	"Piotr Wojtaszczyk" <piotr.wojtaszczyk@timesys.com>,
	"Parthiban Veerasooran" <parthiban.veerasooran@microchip.com>,
	"Timur Tabi" <timur@kernel.org>,
	nic_swsd@realtek.com, "Byungho An" <bh74.an@samsung.com>,
	"Steve Glendinning" <steve.glendinning@shawell.net>,
	"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"FUJITA Tomonori" <fujita.tomonori@gmail.com>,
	"Siddharth Vadapalli" <s-vadapalli@ti.com>,
	"Roger Quadros" <rogerq@kernel.org>,
	"Jiawen Wu" <jiawenwu@trustnetic.com>,
	"Mengyuan Lou" <mengyuanlou@net-swift.com>,
	"Thangaraj Samynathan" <Thangaraj.S@microchip.com>,
	"Sebastian Reichel" <sre@kernel.org>,
	"Simon Horman" <horms@kernel.org>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	devicetree@vger.kernel.org, imx@lists.linux.dev,
	linux-arm-kernel@lists.infradead.org,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-omap@vger.kernel.org, linux-usb@vger.kernel.org,
	linux-pm@vger.kernel.org
Subject: Re: [PATCH net-next v4 0/4] net: mdio: support dynamic OF device changes
Date: Fri, 7 Aug 2026 19:14:27 +0200	[thread overview]
Message-ID: <4aeebecb-81fe-4f09-9dfe-a3be2f778bb8@lunn.ch> (raw)
In-Reply-To: <CADvTj4qxGVw+PW2LeF-a3h1XfmirQZGfJA9-6Czt72XASbVLBQ@mail.gmail.com>

> I guess it can also be used like this for live dt modification:

A guess is not good enough. Give us a concrete, in kernel use cases.

> AFAIU the patches other than the last one are still relevant regardless
> since they are fixing a bunch of generic mdio safety issues in code that
> has users since MDIO maps already change at runtime through non-OF
> paths(i.e. SFP insertion/removal).

Fixes are fine, but please word the commit message around real things
that can happen in todays kernel. If it is a race condition, such bug
reports often show the call stack of the two racing threads.

Do you have a board with an SFP cage? Can you test your change.

   Andrew

  reply	other threads:[~2026-08-07 17:15 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-07  3:54 [PATCH net-next v4 0/4] net: mdio: support dynamic OF device changes James Hilliard
2026-08-07  3:54 ` [PATCH net-next v4 1/4] net: phy: cache MDIO bus owner before dropping PHY reference James Hilliard
2026-08-07  3:54 ` [PATCH net-next v4 2/4] net: mdio: factor out OF child registration helpers James Hilliard
2026-08-07  3:54 ` [PATCH net-next v4 3/4] net: mdio: make device map changes hotplug-safe James Hilliard
2026-08-07  3:54 ` [PATCH net-next v4 4/4] net: mdio: support dynamic OF device changes James Hilliard
2026-08-07 13:15 ` [PATCH net-next v4 0/4] " Andrew Lunn
2026-08-07 14:59   ` James Hilliard
2026-08-07 15:09     ` Andrew Lunn
2026-08-07 16:41       ` James Hilliard
2026-08-07 17:14         ` Andrew Lunn [this message]
2026-08-07 18:48           ` James Hilliard
2026-08-07 19:16             ` Andrew Lunn
2026-08-07 19:33               ` James Hilliard
2026-08-07 20:25                 ` Andrew Lunn
2026-08-07 22:32                   ` James Hilliard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4aeebecb-81fe-4f09-9dfe-a3be2f778bb8@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=Thangaraj.S@microchip.com \
    --cc=UNGLinuxDriver@microchip.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=andreas@gaisler.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=bh74.an@samsung.com \
    --cc=bryan.whitehead@microchip.com \
    --cc=ciprian.regus@analog.com \
    --cc=conor.dooley@microchip.com \
    --cc=davem@davemloft.net \
    --cc=devicetree@vger.kernel.org \
    --cc=edumazet@google.com \
    --cc=f.fainelli@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=frank.li@nxp.com \
    --cc=fujita.tomonori@gmail.com \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=iyappan@os.amperecomputing.com \
    --cc=james.hilliard1@gmail.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=jonas.gorski@gmail.com \
    --cc=keyur@os.amperecomputing.com \
    --cc=kuba@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.einon@gmail.com \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=mengyuanlou@net-swift.com \
    --cc=michael.chan@broadcom.com \
    --cc=netdev@vger.kernel.org \
    --cc=nic_swsd@realtek.com \
    --cc=olteanv@gmail.com \
    --cc=opendmb@gmail.com \
    --cc=pabeni@redhat.com \
    --cc=parthiban.veerasooran@microchip.com \
    --cc=pavan.chebbi@broadcom.com \
    --cc=piotr.wojtaszczyk@timesys.com \
    --cc=rafal@milecki.pl \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    --cc=s-vadapalli@ti.com \
    --cc=saravanak@kernel.org \
    --cc=shaojijie@huawei.com \
    --cc=shenjian15@huawei.com \
    --cc=shenwei.wang@nxp.com \
    --cc=sre@kernel.org \
    --cc=steve.glendinning@shawell.net \
    --cc=theo.lebrun@bootlin.com \
    --cc=timur@kernel.org \
    --cc=vz@mleia.com \
    --cc=wei.fang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox