From: Birger Koblitz <mail@birger-koblitz.de>
To: Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Chih Kai Hsu <hsu.chih.kai@realtek.com>
Subject: Re: [PATCH net-next v7 2/2] r8152: Add support for the RTL8157 hardware
Date: Thu, 9 Apr 2026 13:18:49 +0200 [thread overview]
Message-ID: <4b0b1179-5840-412c-b4d9-a2d068e89dfd@birger-koblitz.de> (raw)
In-Reply-To: <8b324f8c-f4f8-4e90-b5d6-9b87ec3daf2b@redhat.com>
On 09/04/2026 12:16, Paolo Abeni wrote:
> On 4/4/26 9:57 AM, Birger Koblitz wrote:
>> @@ -6534,8 +6842,11 @@ static void rtl8156_up(struct r8152 *tp)
>> ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3,
>> PLA_MCU_SPDWN_EN);
>>
>> - ocp_word_clr_bits(tp, MCU_TYPE_USB, USB_SPEED_OPTION,
>> - RG_PWRDN_EN | ALL_SPEED_OFF);
>> + ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, PLA_MCU_SPDWN_EN);
>
> AI review notes that the above leads to 2 consecutive:
>
> ocp_word_clr_bits(tp, MCU_TYPE_PLA, PLA_MAC_PWR_CTRL3, PLA_MCU_SPDWN_EN);
>
> with slightly different formatting, likely C&P error?!?
>
> I think this is better handled with a follow-up, if needed, as I don't
> see any possible issue out of it.
>
> Other AI comments look not relevant.
Thanks a lot, Paolo!
I will follow up on this for sure, there is also the RTL8159...
I also contacted the Realtek devs, but have not heard back so far, probably needs
internal escalation...
Birger
next prev parent reply other threads:[~2026-04-09 11:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-04 7:57 [PATCH net-next v7 0/2] r8152: Add support for the RTL8157 5Gbit USB Ethernet chip Birger Koblitz
2026-04-04 7:57 ` [PATCH net-next v7 1/2] r8152: Add support for 5Gbit Link Speeds and EEE Birger Koblitz
2026-04-04 7:57 ` [PATCH net-next v7 2/2] r8152: Add support for the RTL8157 hardware Birger Koblitz
2026-04-09 10:16 ` Paolo Abeni
2026-04-09 11:18 ` Birger Koblitz [this message]
2026-04-09 10:30 ` [PATCH net-next v7 0/2] r8152: Add support for the RTL8157 5Gbit USB Ethernet chip patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b0b1179-5840-412c-b4d9-a2d068e89dfd@birger-koblitz.de \
--to=mail@birger-koblitz.de \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hsu.chih.kai@realtek.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox