From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 569CB52CCDB for ; Tue, 29 Sep 2026 14:58:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790693925; cv=none; b=Pc7+y3VAq8jMVzrT0vA6i6+1XlVDHVWzhKrndvSKwN3o4W90JgHSv4RuqguPHDCku0vxUDJCLWSH5UBCKxEeO8JhGKuNECfXK62WIkM+RJSDTkEgRSPq8ilDeTxv7RuyzpsdXkFWqJoelWLcDgUxKMNX7n/GyS+YYgDKCpzhOng= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790693925; c=relaxed/simple; bh=EqAVcdyv3bdh5PWijfipsTsljh3WRwAlRWBBEdBJcZQ=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=A3dIkSGZ7uuuLB7yMeYRNHCSYkCntZWy7+5dioELkfwSwjIlge301PMIFtCmlNo3aRIfOeoV3eytajpabskzDJekNZzibSJl2F++0fpKw4sxMDTAktwn7igazO0m9wnenMn2tkWG66l4aWMXMpVB0Awrojh/CFxFTvEKujkZJ6Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=h6+S91ec; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c3Mp7Dry; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="h6+S91ec"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c3Mp7Dry" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 68TCw9K93301691 for ; Tue, 29 Sep 2026 14:58:32 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Cfew/DLGWZ2OWSHmGvnAzyCDWtCayHiP7Z8vNY3IhS8=; b=h6+S91ectDgEyORG S1jC5DakWLX5QfDmaOXupVyAUzAGuOXi88d6bBwKqvIQGCsuL0YIu0GSI5K1dDyv J8bOw0UDSh/3XHF9GvSrmnSntzt5mkMJnVkDNApC/xgYaA907OS93mW0HS4eWo84 /ezJpFIWlELErhW9JlZLMVPLlsWf3H6SfamIkCmxuEtq9utV7ic+QELL9ySiwBsu eVInksBK4gqmVApUF1aFfQ0+RaL0LrZoA2ObNub+uBefTLRjEALsut/maBO9QbB7 n4Iuk1yq4FMubDnE2lSgErY/P1CdAPQh85Hw0JGmgDvEaMLlqdQV+YecfhY2koSr i00vmQ== Received: from mail-qv1-f72.google.com (mail-qv1-f72.google.com [209.85.219.72]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4h0dsx0kdt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 29 Sep 2026 14:58:32 +0000 (GMT) Received: by mail-qv1-f72.google.com with SMTP id 6a1803df08f44-91454ecbd2fso74459816d6.1 for ; Tue, 29 Sep 2026 07:58:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1790693911; x=1791298711; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Cfew/DLGWZ2OWSHmGvnAzyCDWtCayHiP7Z8vNY3IhS8=; b=c3Mp7DryE6lf5INug55hBEZKzqaeciJzfTFBKGnNP96nAfwT6SRjxyQnxHNzn7WnhM xRdEZLJMV/RfewuvtqKpsQVQ+YJtLoJUer4FY9ti8kjlpDvtKcZqop/YotW9axgfGxvr bWbLhYQdQKAhuuGEpI1uzQ3TjgOF6TTq7EfQ5F6JHBZ8175dIsVTVs6C1mxNZLkL52bm yNoRTdSYB4Z80oHKbg5D3a8zuFVI4N2m8OZSDuu+3fPAVEqKsDzhE1OyyVtNFrfIacP/ yKg04supWUBfXLg1L+2jgfhP2GPliaMAXceWUMOcDZa5VmXTABMtuOS/yAaQj39ATygB 0OQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790693911; x=1791298711; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Cfew/DLGWZ2OWSHmGvnAzyCDWtCayHiP7Z8vNY3IhS8=; b=JDk3P0bvPv3XZ9oIYs27IPxcRiODKhZ0Jk3t/U4vgxE6mBwTJC+2sfVEiDX8BI1QRj bGNPexWEi5IH66aFOJ8NwEkizL4nmcbMJMCfr4B9iozbzAvHuDI0W2ysTS1CLBcGWJtR pmki3MAWKPPwZUur7ir1qyHsXt9DDUE5qB78QNR+IHhC/Vvgqy0ua9O2Ef5cyqMeP05x HMNKaBJWfCbBI4kZp6/BLiQW6Ibuw3o0lQOAQqJmOaM45jMCf6ra9ffh5tg2oDryMbwi xihgtf8y7R7vk01GFQTWpC9kU8ALI3AxWMTJ9RRjxIn3pRL4WbJOTI9A2iqdQynJs+0/ H5qg== X-Forwarded-Encrypted: i=1; AKwUvBwDO3IRsfmtVDK48ohfp1ysGWltSyHdLy21JVaW9URcpSmKuOYqkDhBWE5vgMXh5ROFfdStYzQ=@vger.kernel.org X-Gm-Message-State: AFuF++kMpPrttOV5xhTKBT08o9u2YfjLcsxUT4VLtIlQoy8+OliKoNYN jqjOafTdqACYTz1T5a2GpNYdSFB93vQw0uwwC76ujyR1WA1FT1EcKXwClT5bPANet/QZR33lyO4 levbxwZ2DBBteUaPIpvN96kga0JVRVzlrLUUfC569Th7Uxq4zBcpRa3luHvo= X-Gm-Gg: AYBFou11DpSqwjh4URN1zCA0YrwC/t8KK9hIhiS5yE8wAnLTgQZp/Krd5+c+5YelQuK Pf336zzGsFVLahb/VzzDKdEDoNJK5AW4n7o3EAJM9Ge3nQrsRcfp6kJDNieJCElEWOU435u+/KW JZ5Ui4ZlCFdNrfTqRF9xOERzJgROMRtpa2io4YPtUOTNfv4z0lRSaDtbh4YMXu1zb1Pw7n8G9SB rSWM4JHNoFsQKDtgk6VKvG55n9zz/mHpNLlsSHcM/1acD9uWWRByUkPG172suKXt80m4abTCl7Q zdh1jvrRx5bNKT8e7ixq8ndLYoOp7vfPfVXHm4ZW5HXZD6wKL4Xju7U82Eq6Sr2tDj2EBtYBF/G QDvP3h5A3tMhhYUVoyJXYWpIk/PKGH/hnWimY X-Received: by 2002:a05:6214:390a:b0:914:4601:dfd8 with SMTP id 6a1803df08f44-9144601e535mr213690416d6.10.1790693911031; Tue, 29 Sep 2026 07:58:31 -0700 (PDT) X-Received: by 2002:a05:6214:390a:b0:914:4601:dfd8 with SMTP id 6a1803df08f44-9144601e535mr213689766d6.10.1790693910318; Tue, 29 Sep 2026 07:58:30 -0700 (PDT) Received: from [192.168.0.116] ([124.123.146.251]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-9178d377464sm12112356d6.41.2026.09.29.07.58.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2026 07:58:29 -0700 (PDT) Message-ID: <4b149801-0846-455f-83aa-a222219d01be@oss.qualcomm.com> Date: Tue, 29 Sep 2026 20:28:22 +0530 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next v2 0/2] net: wwan: qcom_bam_dmux: Add restricted DMA pool support To: Stephan Gerhold Cc: Stephan Gerhold , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Loic Poulain , Sergey Ryazanov , Johannes Berg , linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Deepak Kumar Singh References: <20260920-qcom-bam-dmux-vmid-ext-v2-0-ef5ca2178378@oss.qualcomm.com> Content-Language: en-US From: Vishnu Santhosh In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwOTI5MDA1OSBTYWx0ZWRfX7YbBsM/lh8zw yuX1UnW4C7maM2E+t5FMonHTPgcXRNjyPpWWJMj+uVivgRYxZQGXdbxY9fieLj1jusnBxw5G5jC /RyPRt/B5N/lxgDCMGdVyfdTcu7zT8O536JsZMBih2mvA8gEV4v6YeNbHvDrGPV3fWMVbBfl4Or Hinj1I//gzuGJpD9HbL+kKa+iwjykuoII5hseoG9QSgic3s9g0E8uUjdmsznLhNly4P7kf25Zvi 4/Pi9w9FMSRumNxWT+i/ndH8zkOMuwhADohVAh/QkmdmTKD3tZ0K1uXa0HIirQbd3DSrzZI5oYw 540Iu5KyK+RvUGmsFGrNR7zWHDxp1QBiMvVgjHX3Z/u7GQpNinCdS8E9R/D1oGyaZ/m4y78Pmi2 9RBod04pvr12jXzm/BMpbpLRd/Np6c8vHDg/u0x7n19Xyj7LbzWS5ixkxPEE1gcGKgtQh6pyIHX CIWuQAtsuQvzfa6DEfg== X-Proofpoint-ORIG-GUID: oEYaptKiYbhgYu5ca6kKLbCL0irK8dvH X-Proofpoint-Spam-Info: AW1haW4tMjYwOTI5MDA1OSBTYWx0ZWRfX95sPAe7OZ7RT KYCPYE8RzaOjRFwNzEoJnktl18/+79pbzV1/Q3ZIUvD0onu3g9YY3nay9jSbG7hPIkPgajydRVJ r0ih8tt9hmVqZqwWO9uF/j9EzRaXekM= X-Proofpoint-GUID: oEYaptKiYbhgYu5ca6kKLbCL0irK8dvH X-Authority-Analysis: v=2.4 cv=DqvDa2/+ c=1 sm=1 tr=0 ts=6abbd218 cx=c_pps a=7E5Bxpl4vBhpaufnMqZlrw==:117 a=K/78aEDNEn2Q/Yuv7mVN5Q==:17 a=IkcTkHD0fZMA:10 a=VdqzKS8jKosA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=VwQbUJbxAAAA:8 a=EUspDBNiAAAA:8 a=uW-ob52F1wccIURrHgMA:9 a=QEXdDO2ut3YA:10 a=pJ04lnu7RYOZP9TFuWaZ:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-09-29_04,2026-09-21_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 spamscore=0 phishscore=0 adultscore=0 malwarescore=0 suspectscore=0 lowpriorityscore=0 impostorscore=0 clxscore=1015 priorityscore=1501 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2609040000 definitions=main-2609290059 On 29-09-2026 01:44 pm, Stephan Gerhold wrote: > On Mon, Sep 28, 2026 at 04:02:47PM +0530, Vishnu Santhosh wrote: >> On 20-09-2026 08:32 am, Vishnu Santhosh wrote: >>> Some Qualcomm SoCs, such as Shikra, run the modem in a separate security >>> domain with restricted access to system memory. BAM-DMUX DMA mappings >>> and BAM descriptor FIFOs must therefore be constrained to a designated >>> memory region that can be shared with the modem. Accesses outside that >>> region can trigger an XPU violation. >>> >>> Add memory-region and qcom,vmid properties to the BAM-DMUX binding. >>> When qcom,vmid is present, the driver SCM-assigns the entire restricted >>> DMA pool to the local and remote execution environments before requesting >>> the DMA channels. >>> >>> The restricted pool then contains the BAM-DMUX mappings. When the BAM DMA >>> controller references the same pool, its descriptor FIFOs are covered by >>> the assignment as well. >>> >>> A related binding change allows the BAM DMA controller to use the same >>> restricted pool for descriptor FIFO allocations: >>> >>> https://lore.kernel.org/all/20260920-qcom-bam-dma-vmid-ext-v2-1-4dbbff0e57c8@oss.qualcomm.com/ >>> ("dt-bindings: dma: qcom,bam-dma: Allow memory-region property") >>> >>> Signed-off-by: Vishnu Santhosh >>> --- >>> Changes in v2: >>> - Replace the Shikra-specific compatible and coherent RX allocation with >>> memory-region and qcom,vmid properties. >>> - Use a restricted DMA pool for BAM-DMUX mappings and BAM descriptor FIFOs. >>> - SCM-assign the complete pool before requesting the DMA channels. >>> - Validate the remote VMID and restricted DMA pool configuration. >>> - Link to v1: https://lore.kernel.org/r/20260714-qcom-bam-dmux-vmid-ext-v1-0-3f29da7cca76@oss.qualcomm.com >>> >>> --- >>> Vishnu Santhosh (2): >>> dt-bindings: net: qcom,bam-dmux: Add memory-region and qcom,vmid properties >>> net: wwan: qcom_bam_dmux: Assign restricted DMA pool to remote processor >>> >>> .../devicetree/bindings/net/qcom,bam-dmux.yaml | 38 +++++++++ >>> drivers/net/wwan/Kconfig | 1 + >>> drivers/net/wwan/qcom_bam_dmux.c | 95 ++++++++++++++++++++++ >>> 3 files changed, 134 insertions(+) >>> --- >>> base-commit: 8830e65ed46de41f849eefb8ba227d4852c460f6 >>> change-id: 20260714-qcom-bam-dmux-vmid-ext-d9289db310c1 >>> >>> Best regards, >> Hi Stephan, >> >> I followed your suggestion and updated v2 to use the restricted DMA pool. >> >> Please let me know if this approach and the implementation look reasonable and >> meets your expectations. >> > Thanks, the approach looks good to me. You received some comments from > others and Sashiko already, so I will make a more thorough review from > my side once you have addressed (or at least considered) them for v3. > > Thanks, > Stephan Thanks for confirming the approach. I will address the remaining comments as well, so that you can proceed with thorough review. Thanks, Vishnu