From: Roger Quadros <rogerq@kernel.org>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, shuah@kernel.org, s-vadapalli@ti.com,
r-gunasekaran@ti.com, vigneshr@ti.com, srk@ti.com,
horms@kernel.org, p-varis@ti.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v8 net-next 09/11] net: ethernet: ti: am65-cpsw-qos: Add Frame Preemption MAC Merge support
Date: Thu, 14 Dec 2023 15:53:57 +0200 [thread overview]
Message-ID: <4b20b60a-c72d-4283-a8af-ff82bc5d1b19@kernel.org> (raw)
In-Reply-To: <20231214135039.6lcixyy7z6u56zgv@skbuf>
On 14/12/2023 15:50, Vladimir Oltean wrote:
> On Thu, Dec 14, 2023 at 03:44:03PM +0200, Roger Quadros wrote:
>> On 14/12/2023 13:04, Vladimir Oltean wrote:
>>>> + /* verify_timeout_count can only be set at valid link */
>>>> + if (cfg->verify_time > 0)
>>>> + port->qos.iet.verify_time_ms = cfg->verify_time;
>>>> + else
>>>> + port->qos.iet.verify_time_ms = 10;
>>>
>>> I don't think I understand what the check is for? The netlink policy for
>>> ETHTOOL_A_MM_VERIFY_TIME limits the range between 1 ms and 128 ms.
>>> How can it be 0?
>>
>> I didn't check ETHTOOL_A_MM_VERIFY_TIME before.
>
> Not even when the exact same policy was rejecting the verify-time set by
> LLDP in v6, for being larger than the upper limit of 128 ms? :-/
Sorry. I did check it before but overlooked it here. My memory seems to be failing me. :(
--
cheers,
-roger
next prev parent reply other threads:[~2023-12-14 13:54 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-13 11:07 [PATCH v8 net-next 00/11] net: ethernet: am65-cpsw: Add mqprio, frame pre-emption & coalescing Roger Quadros
2023-12-13 11:07 ` [PATCH v8 net-next 01/11] selftests: forwarding: ethtool_mm: support devices with higher rx-min-frag-size Roger Quadros
2023-12-13 11:07 ` [PATCH v8 net-next 02/11] selftests: forwarding: ethtool_mm: fall back to aggregate if device does not report pMAC stats Roger Quadros
2023-12-14 14:16 ` Vladimir Oltean
2023-12-14 17:16 ` Roger Quadros
2023-12-13 11:07 ` [PATCH v8 net-next 03/11] net: ethernet: am65-cpsw: Build am65-cpsw-qos only if required Roger Quadros
2023-12-13 11:07 ` [PATCH v8 net-next 04/11] net: ethernet: am65-cpsw: Rename TI_AM65_CPSW_TAS to TI_AM65_CPSW_QOS Roger Quadros
2023-12-13 11:07 ` [PATCH v8 net-next 05/11] net: ethernet: am65-cpsw: cleanup TAPRIO handling Roger Quadros
2023-12-14 11:23 ` Vladimir Oltean
2023-12-14 13:36 ` Roger Quadros
2023-12-14 13:41 ` Vladimir Oltean
2023-12-14 13:50 ` Roger Quadros
2023-12-13 11:07 ` [PATCH v8 net-next 06/11] net: ethernet: ti: am65-cpsw: Move code to avoid forward declaration Roger Quadros
2023-12-14 11:09 ` Vladimir Oltean
2023-12-13 11:07 ` [PATCH v8 net-next 07/11] net: ethernet: am65-cpsw: Move register definitions to header file Roger Quadros
2023-12-14 11:08 ` Vladimir Oltean
2023-12-13 11:07 ` [PATCH v8 net-next 08/11] net: ethernet: ti: am65-cpsw: add mqprio qdisc offload in channel mode Roger Quadros
2023-12-14 11:06 ` Vladimir Oltean
2023-12-13 11:07 ` [PATCH v8 net-next 09/11] net: ethernet: ti: am65-cpsw-qos: Add Frame Preemption MAC Merge support Roger Quadros
2023-12-14 11:04 ` Vladimir Oltean
2023-12-14 13:44 ` Roger Quadros
2023-12-14 13:50 ` Vladimir Oltean
2023-12-14 13:53 ` Roger Quadros [this message]
2023-12-13 11:07 ` [PATCH v8 net-next 10/11] net: ethernet: ti: am65-cpsw: add sw tx/rx irq coalescing based on hrtimers Roger Quadros
2023-12-13 11:07 ` [PATCH v8 net-next 11/11] net: ethernet: ti: am65-cpsw: Fix get_eth_mac_stats Roger Quadros
2023-12-13 13:54 ` Vladimir Oltean
2023-12-14 10:04 ` Roger Quadros
2023-12-15 11:31 ` Roger Quadros
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b20b60a-c72d-4283-a8af-ff82bc5d1b19@kernel.org \
--to=rogerq@kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=p-varis@ti.com \
--cc=pabeni@redhat.com \
--cc=r-gunasekaran@ti.com \
--cc=s-vadapalli@ti.com \
--cc=shuah@kernel.org \
--cc=srk@ti.com \
--cc=vigneshr@ti.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).