From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7991C07E96 for ; Fri, 9 Jul 2021 02:43:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C6E5961463 for ; Fri, 9 Jul 2021 02:43:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230493AbhGICq0 (ORCPT ); Thu, 8 Jul 2021 22:46:26 -0400 Received: from mga01.intel.com ([192.55.52.88]:36767 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230336AbhGICqZ (ORCPT ); Thu, 8 Jul 2021 22:46:25 -0400 X-IronPort-AV: E=McAfee;i="6200,9189,10039"; a="231399821" X-IronPort-AV: E=Sophos;i="5.84,225,1620716400"; d="scan'208";a="231399821" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 19:43:42 -0700 X-IronPort-AV: E=Sophos;i="5.84,225,1620716400"; d="scan'208";a="564861698" Received: from npujari-mobl.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.213.167.42]) by fmsmga001-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 08 Jul 2021 19:43:41 -0700 Subject: Re: [PATCH v2 5/6] platform/x86: intel_tdx_attest: Add TDX Guest attestation interface driver To: Dan Williams , Andi Kleen Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Peter Zijlstra , Andy Lutomirski , Hans de Goede , Mark Gross , Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Peter H Anvin , Dave Hansen , Tony Luck , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , X86 ML , Linux Kernel Mailing List , platform-driver-x86@vger.kernel.org, bpf@vger.kernel.org, Netdev References: <20210707204249.3046665-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210707204249.3046665-6-sathyanarayanan.kuppuswamy@linux.intel.com> <24d8fd58-36c1-0e89-4142-28f29e2c434b@linux.intel.com> <4972fc1a-1ffb-2b6d-e764-471210df96a3@linux.intel.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: <4b22be93-a401-6b96-48e1-18a71a6a17bc@linux.intel.com> Date: Thu, 8 Jul 2021 19:43:40 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 7/8/21 7:04 PM, Dan Williams wrote: > Ok, not my first choice for how to handle the allocation side of that, > but not broken. > > I'd still feel better if there was an actual data structure assigned > to file->private_data rather than using that 'void *' pointer directly > and casting throughout the driver. We can add a data structure if we have more member requirements. Currently we only need to pass the memory pointer. But after moving memory allocation to init code (even for vmap), we may not need to use this private pointer. -- Sathyanarayanan Kuppuswamy Linux Kernel Developer