Re: [PATCH net v4] failover: allow name change on IFF_UP slave interfaces

[si-wei liu <si-wei.liu@oracle.com>]

On 3/29/2019 8:34 AM, Jiri Pirko wrote:
> Fri, Mar 29, 2019 at 04:15:12PM CET, stephen@networkplumber.org wrote:
>> On Thu, 28 Mar 2019 19:47:27 -0400
>> Si-Wei Liu <si-wei.liu@oracle.com> wrote:
>>
>>> +	if (unlikely(dev->flags & IFF_UP)) {
>>> +		struct netdev_notifier_change_info change_info;
>>> +
>>> +		change_info.flags_changed = 0;
>> Simpler to use structure initialization, which also avoid any chance
>> of unititialized fields.
>>
>> 		struct netdev_notifier_change_info change_info
>> 			= { .flags_changed =  0 };
>   
> In fact, you can do just:
> 	struct netdev_notifier_change_info change_info = {};
> to achieve the same.
Hmm, although it's same in effect, I'd opt for keeping explicit 
initialization around flags_changed, which has the benefit in terms of 
cscope/tags referencing. Just very minor point though.

Let me if you think it otherwise...

-Siwei