From: Sowmini Varadhan <sowmini.varadhan@oracle.com>
To: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: chien.yen@oracle.com, davem@davemloft.net,
rds-devel@oss.oracle.com, agrover@redhat.com, clm@fb.com,
zab@zabbo.net, ajaykumar.hotchandani@oracle.com,
sergei.shtylyov@cogentembedded.com,
Sowmini Varadhan <sowmini.varadhan@oracle.com>
Subject: [PATCHv2 5/6] RDS: rds_send_xmit is called under a spinlock, lets not do a cond_resched()
Date: Thu, 2 Apr 2015 10:19:39 -0400 [thread overview]
Message-ID: <4b4fb362d20a5c97165f929d049065518f7fa108.1427983908.git.sowmini.varadhan@oracle.com> (raw)
In-Reply-To: <cover.1427983908.git.sowmini.varadhan@oracle.com>
In-Reply-To: <cover.1427983908.git.sowmini.varadhan@oracle.com>
Original patch by Chris Mason
Signed-off-by: Sowmini Varadhan <sowmini.varadhan@oracle.com>
---
net/rds/send.c | 14 ++------------
1 files changed, 2 insertions(+), 12 deletions(-)
diff --git a/net/rds/send.c b/net/rds/send.c
index aec3f9d..23135a8 100644
--- a/net/rds/send.c
+++ b/net/rds/send.c
@@ -199,7 +199,6 @@ int rds_send_xmit(struct rds_connection *conn)
same_rm++;
if (same_rm >= 4096) {
printk_ratelimited(KERN_ERR "RDS: Stuck rm\n");
- cond_resched();
ret = -EAGAIN;
break;
}
@@ -427,17 +426,8 @@ int rds_send_xmit(struct rds_connection *conn)
smp_mb();
if (!list_empty(&conn->c_send_queue) &&
send_gen == conn->c_send_gen) {
- cond_resched();
- /* repeat our check after the resched in case
- * someone else was kind enough to empty or process
- * the queue
- */
- smp_mb();
- if (!list_empty(&conn->c_send_queue) &&
- send_gen == conn->c_send_gen) {
- rds_stats_inc(s_send_lock_queue_raced);
- goto restart;
- }
+ rds_stats_inc(s_send_lock_queue_raced);
+ goto restart;
}
}
out:
--
1.7.1
next prev parent reply other threads:[~2015-04-02 14:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-02 14:19 [PATCHv2 0/6] RDS: RDS core bug fixes Sowmini Varadhan
2015-04-02 14:19 ` [PATCHv2 1/6] RDS: Re-add pf/sol access via sysctl Sowmini Varadhan
2015-04-02 14:19 ` [PATCHv2 2/6] RDS: only use passive connections when addresses match Sowmini Varadhan
2015-04-02 14:19 ` [PATCHv2 3/6] rds: check for excessive looping in rds_send_xmit Sowmini Varadhan
2015-04-02 18:08 ` David Miller
2015-04-02 14:19 ` [PATCHv2 4/6] RDS: make sure not to loop forever inside rds_send_xmit Sowmini Varadhan
2015-04-02 14:19 ` Sowmini Varadhan [this message]
2015-04-02 14:19 ` [PATCHv2 6/6] RDS: don't trust the LL_SEND_FULL bit Sowmini Varadhan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b4fb362d20a5c97165f929d049065518f7fa108.1427983908.git.sowmini.varadhan@oracle.com \
--to=sowmini.varadhan@oracle.com \
--cc=agrover@redhat.com \
--cc=ajaykumar.hotchandani@oracle.com \
--cc=chien.yen@oracle.com \
--cc=clm@fb.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=zab@zabbo.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).