From: Paolo Abeni <pabeni@redhat.com>
To: hexlabsecurity@proton.me,
Sidraya Jayagond <sidraya@linux.ibm.com>,
Jakub Kicinski <kuba@kernel.org>,
"D. Wythe" <alibuda@linux.alibaba.com>,
"David S. Miller" <davem@davemloft.net>,
Wen Gu <guwen@linux.alibaba.com>,
Wenjia Zhang <wenjia@linux.ibm.com>,
Eric Dumazet <edumazet@google.com>,
Tony Lu <tonylu@linux.alibaba.com>,
Mahanta Jambigi <mjambigi@linux.ibm.com>,
Dust Li <dust.li@linux.alibaba.com>
Cc: linux-s390@vger.kernel.org, linux-rdma@vger.kernel.org,
Ursula Braun <ubraun@linux.ibm.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Stefan Raspl <raspl@linux.ibm.com>,
Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net v5 1/3] net/smc: bound the wire-controlled producer cursor to the RMB
Date: Tue, 28 Jul 2026 15:50:02 +0200 [thread overview]
Message-ID: <4b5f67a2-5624-4adb-812a-bd87d99416ed@redhat.com> (raw)
In-Reply-To: <20260723-b4-disp-0d07164f-v5-1-6a9e235dbc4e@proton.me>
On 7/24/26 2:23 AM, Bryam Vargas via B4 Relay wrote:
> @@ -246,8 +256,13 @@ static inline void smcr_cdc_msg_to_host(struct smc_host_cdc_msg *local,
> local->len = peer->len;
> local->seqno = ntohs(peer->seqno);
> local->token = ntohl(peer->token);
> - smc_cdc_cursor_to_host(&local->prod, &peer->prod, conn);
> - smc_cdc_cursor_to_host(&local->cons, &peer->cons, conn);
> + /* bound the wire-controlled producer cursor to our RMB (used as a raw
> + * index by the urgent path); leave the consumer cursor unbounded -- it
> + * indexes the peer's RMB and is bounded by peer_rmbe_size.
> + */
> + smc_cdc_cursor_to_host(&local->prod, &peer->prod, conn,
> + conn->rmb_desc->len);
Sashiko gemini suspects the above may cause a Null ptr dereference:
https://sashiko.dev/#/patchset/20260723-b4-disp-0d07164f-v5-0-6a9e235dbc4e%40proton.me
/P
next prev parent reply other threads:[~2026-07-28 13:50 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-24 0:23 [PATCH net v5 0/3] net/smc: bound wire-controlled CDC cursors against the local buffers Bryam Vargas via B4 Relay
2026-07-24 0:23 ` [PATCH net v5 1/3] net/smc: bound the wire-controlled producer cursor to the RMB Bryam Vargas via B4 Relay
2026-07-28 13:50 ` Paolo Abeni [this message]
2026-07-28 17:25 ` Bryam Vargas
2026-08-14 6:03 ` Sidraya Jayagond
2026-07-24 0:23 ` [PATCH net v5 2/3] net/smc: bound the receive length to the RMB in smc_rx_recvmsg() Bryam Vargas via B4 Relay
2026-08-14 6:03 ` Sidraya Jayagond
2026-07-24 0:23 ` [PATCH net v5 3/3] net/smc: bound the send length to the send buffer in smc_tx_sendmsg() Bryam Vargas via B4 Relay
2026-08-14 6:04 ` Sidraya Jayagond
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b5f67a2-5624-4adb-812a-bd87d99416ed@redhat.com \
--to=pabeni@redhat.com \
--cc=alibuda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=dust.li@linux.alibaba.com \
--cc=edumazet@google.com \
--cc=guwen@linux.alibaba.com \
--cc=hexlabsecurity@proton.me \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjambigi@linux.ibm.com \
--cc=netdev@vger.kernel.org \
--cc=raspl@linux.ibm.com \
--cc=sidraya@linux.ibm.com \
--cc=tonylu@linux.alibaba.com \
--cc=ubraun@linux.ibm.com \
--cc=wenjia@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox