From mboxrd@z Thu Jan 1 00:00:00 1970 From: Subash Abhinov Kasiviswanathan Subject: Re: Qualcomm rmnet driver and qmi_wwan Date: Sat, 09 Jun 2018 11:55:22 -0600 Message-ID: <4b74bb1d92b9e9351bc504d18f96116b@codeaurora.org> References: <2a96c941b6699827ea6ac1ce3603fae5@codeaurora.org> <9786ab4bf4e425566f55a0654911ab788f3f1a38.camel@redhat.com> <8a77f905ddcd6a8136dd9f2d5de11438@codeaurora.org> <87k1r914df.fsf@miraculix.mork.no> <8ad179b53c866ef67823570d055071a3@codeaurora.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=_710fa961174e63a42f89568769d53118" Cc: =?UTF-8?Q?Bj=C3=B8rn_Mork?= , Dan Williams , netdev@vger.kernel.org To: Daniele Palmas Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:43356 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753442AbeFIRzX (ORCPT ); Sat, 9 Jun 2018 13:55:23 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: --=_710fa961174e63a42f89568769d53118 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=US-ASCII; format=flowed > thanks, I will test it on Monday. > > Just a question for my knowledge: is the new sysfs attribute really > needed? I mean, is there not any other way to understand from qmi_wwan > without user intervention that there is the rmnet device attached? > > Regards, > Daniele > Hi Daniele You can check for the rx_handler attached to qmi_wwan dev and see if it belongs to rmnet. You can use the attached patch for it but it think the sysfs way might be a bit cleaner. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project --=_710fa961174e63a42f89568769d53118 Content-Transfer-Encoding: base64 Content-Type: text/x-diff; name=0001-net-qmi_wwan-Allow-packets-to-pass-through-to-rmnet.patch Content-Disposition: attachment; filename=0001-net-qmi_wwan-Allow-packets-to-pass-through-to-rmnet.patch; size=3460 RnJvbSBmN2EyYjkwOTQ4ZGE0N2FkZTFiMzQ1ZWRkYjM3YjcyMWY1YWI2NWY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdWJhc2ggQWJoaW5vdiBLYXNpdmlzd2FuYXRoYW4gPHN1YmFz aGFiQGNvZGVhdXJvcmEub3JnPgpEYXRlOiBTYXQsIDkgSnVuIDIwMTggMTE6MTQ6MjIgLTA2MDAK U3ViamVjdDogW1BBVENIXSBuZXQ6IHFtaV93d2FuOiBBbGxvdyBwYWNrZXRzIHRvIHBhc3MgdGhy b3VnaCB0byBybW5ldAoKUGFzcyB0aHJvdWdoIG1vZGUgaXMgdG8gYWxsb3cgcGFja2V0cyBpbiBN QVAgZm9ybWF0IHRvIGJlIHBhc3NlZApvbiB0byBybW5ldCBpZiB0aGUgcm1uZXQgcnggaGFuZGxl ciBpcyBhdHRhY2hlZCB0byBpdC4KClNpZ25lZC1vZmYtYnk6IFN1YmFzaCBBYmhpbm92IEthc2l2 aXN3YW5hdGhhbiA8c3ViYXNoYWJAY29kZWF1cm9yYS5vcmc+Ci0tLQogZHJpdmVycy9uZXQvZXRo ZXJuZXQvcXVhbGNvbW0vcm1uZXQvcm1uZXRfY29uZmlnLmMgfCAgNCArKystCiBkcml2ZXJzL25l dC91c2IvcW1pX3d3YW4uYyAgICAgICAgICAgICAgICAgICAgICAgICB8IDEwICsrKysrKysrKysK IGluY2x1ZGUvbGludXgvaWZfcm1uZXQuaCAgICAgICAgICAgICAgICAgICAgICAgICAgIHwgMjAg KysrKysrKysrKysrKysrKysrKysKIDMgZmlsZXMgY2hhbmdlZCwgMzMgaW5zZXJ0aW9ucygrKSwg MSBkZWxldGlvbigtKQogY3JlYXRlIG1vZGUgMTAwNjQ0IGluY2x1ZGUvbGludXgvaWZfcm1uZXQu aAoKZGlmZiAtLWdpdCBhL2RyaXZlcnMvbmV0L2V0aGVybmV0L3F1YWxjb21tL3JtbmV0L3JtbmV0 X2NvbmZpZy5jIGIvZHJpdmVycy9uZXQvZXRoZXJuZXQvcXVhbGNvbW0vcm1uZXQvcm1uZXRfY29u ZmlnLmMKaW5kZXggNWY0ZTQ0Ny4uMTY0YTE4ZiAxMDA2NDQKLS0tIGEvZHJpdmVycy9uZXQvZXRo ZXJuZXQvcXVhbGNvbW0vcm1uZXQvcm1uZXRfY29uZmlnLmMKKysrIGIvZHJpdmVycy9uZXQvZXRo ZXJuZXQvcXVhbGNvbW0vcm1uZXQvcm1uZXRfY29uZmlnLmMKQEAgLTE3LDYgKzE3LDcgQEAKICNp bmNsdWRlIDxsaW51eC9tb2R1bGUuaD4KICNpbmNsdWRlIDxsaW51eC9uZXRsaW5rLmg+CiAjaW5j bHVkZSA8bGludXgvbmV0ZGV2aWNlLmg+CisjaW5jbHVkZSA8bGludXgvaWZfcm1uZXQuaD4KICNp bmNsdWRlICJybW5ldF9jb25maWcuaCIKICNpbmNsdWRlICJybW5ldF9oYW5kbGVycy5oIgogI2lu Y2x1ZGUgInJtbmV0X3ZuZC5oIgpAQCAtNDgsMTAgKzQ5LDExIEBACiAJW0lGTEFfUk1ORVRfRkxB R1NdCT0geyAubGVuID0gc2l6ZW9mKHN0cnVjdCBpZmxhX3JtbmV0X2ZsYWdzKSB9LAogfTsKIAot c3RhdGljIGludCBybW5ldF9pc19yZWFsX2Rldl9yZWdpc3RlcmVkKGNvbnN0IHN0cnVjdCBuZXRf ZGV2aWNlICpyZWFsX2RldikKK2ludCBybW5ldF9pc19yZWFsX2Rldl9yZWdpc3RlcmVkKGNvbnN0 IHN0cnVjdCBuZXRfZGV2aWNlICpyZWFsX2RldikKIHsKIAlyZXR1cm4gcmN1X2FjY2Vzc19wb2lu dGVyKHJlYWxfZGV2LT5yeF9oYW5kbGVyKSA9PSBybW5ldF9yeF9oYW5kbGVyOwogfQorRVhQT1JU X1NZTUJPTChybW5ldF9pc19yZWFsX2Rldl9yZWdpc3RlcmVkKTsKIAogLyogTmVlZHMgcnRubCBs b2NrICovCiBzdGF0aWMgc3RydWN0IHJtbmV0X3BvcnQqCmRpZmYgLS1naXQgYS9kcml2ZXJzL25l dC91c2IvcW1pX3d3YW4uYyBiL2RyaXZlcnMvbmV0L3VzYi9xbWlfd3dhbi5jCmluZGV4IGY1MmE5 YmUuLmFiZGFlNjMgMTAwNjQ0Ci0tLSBhL2RyaXZlcnMvbmV0L3VzYi9xbWlfd3dhbi5jCisrKyBi L2RyaXZlcnMvbmV0L3VzYi9xbWlfd3dhbi5jCkBAIC0yMiw2ICsyMiw3IEBACiAjaW5jbHVkZSA8 bGludXgvdXNiL2NkYy5oPgogI2luY2x1ZGUgPGxpbnV4L3VzYi91c2JuZXQuaD4KICNpbmNsdWRl IDxsaW51eC91c2IvY2RjLXdkbS5oPgorI2luY2x1ZGUgPGxpbnV4L2lmX3JtbmV0Lmg+CiAKIC8q IFRoaXMgZHJpdmVyIHN1cHBvcnRzIHd3YW4gKDNHL0xURS8/KSBkZXZpY2VzIHVzaW5nIGEgdmVu ZG9yCiAgKiBzcGVjaWZpYyBtYW5hZ2VtZW50IHByb3RvY29sIGNhbGxlZCBRdWFsY29tbSBNU00g SW50ZXJmYWNlIChRTUkpIC0KQEAgLTM1NCw2ICszNTUsMTAgQEAgc3RhdGljIHNzaXplX3QgYWRk X211eF9zdG9yZShzdHJ1Y3QgZGV2aWNlICpkLCAgc3RydWN0IGRldmljZV9hdHRyaWJ1dGUgKmF0 dHIsIGMKIAlpZiAoa3N0cnRvdTgoYnVmLCAwLCAmbXV4X2lkKSkKIAkJcmV0dXJuIC1FSU5WQUw7 CiAKKwkvKiBybW5ldCBpcyBhbHJlYWR5IGF0dGFjaGVkIGhlcmUgKi8KKwlpZiAocm1uZXRfaXNf cmVhbF9kZXZfcmVnaXN0ZXJlZCh0b19uZXRfZGV2KGQpKSkKKwkJcmV0dXJuIC1FSU5WQUw7CisK IAkvKiBtdXhfaWQgWzEgLSAweDdmXSByYW5nZSBlbXBpcmljYWxseSBmb3VuZCAqLwogCWlmICht dXhfaWQgPCAxIHx8IG11eF9pZCA+IDB4N2YpCiAJCXJldHVybiAtRUlOVkFMOwpAQCAtNTQzLDYg KzU0OCwxMSBAQCBzdGF0aWMgaW50IHFtaV93d2FuX3J4X2ZpeHVwKHN0cnVjdCB1c2JuZXQgKmRl diwgc3RydWN0IHNrX2J1ZmYgKnNrYikKIAlpZiAoc2tiLT5sZW4gPCBkZXYtPm5ldC0+aGFyZF9o ZWFkZXJfbGVuKQogCQlyZXR1cm4gMDsKIAorCWlmIChyYXdpcCAmJiBybW5ldF9pc19yZWFsX2Rl dl9yZWdpc3RlcmVkKHNrYi0+ZGV2KSkgeworCQlza2ItPnByb3RvY29sID0gaHRvbnMoRVRIX1Bf TUFQKTsKKwkJcmV0dXJuIChuZXRpZl9yeChza2IpID09IE5FVF9SWF9TVUNDRVNTKTsKKwl9CisK IAlpZiAoaW5mby0+ZmxhZ3MgJiBRTUlfV1dBTl9GTEFHX01VWCkKIAkJcmV0dXJuIHFtaW11eF9y eF9maXh1cChkZXYsIHNrYik7CiAKZGlmZiAtLWdpdCBhL2luY2x1ZGUvbGludXgvaWZfcm1uZXQu aCBiL2luY2x1ZGUvbGludXgvaWZfcm1uZXQuaApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi43YTdmYjk2Ci0tLSAvZGV2L251bGwKKysrIGIvaW5jbHVkZS9saW51eC9pZl9ybW5l dC5oCkBAIC0wLDAgKzEsMjAgQEAKKy8vIFNQRFgtTGljZW5zZS1JZGVudGlmaWVyOiBHUEwtMi4w CisvKgorICogQ29weXJpZ2h0IChjKSAyMDE4LCBUaGUgTGludXggRm91bmRhdGlvbi4gQWxsIHJp Z2h0cyByZXNlcnZlZC4KKyAqCisgKi8KKyNpZm5kZWYgX0xJTlVYX0lGX1JNTkVUX0hfCisjZGVm aW5lIF9MSU5VWF9JRl9STU5FVF9IXworI2luY2x1ZGUgPGxpbnV4L25ldGRldmljZS5oPgorCisj aWYgZGVmaW5lZChDT05GSUdfUk1ORVQpCitleHRlcm4gaW50IHJtbmV0X2lzX3JlYWxfZGV2X3Jl Z2lzdGVyZWQoY29uc3Qgc3RydWN0IG5ldF9kZXZpY2UgKnJlYWxfZGV2KTsKKyNlbHNlCitzdGF0 aWMgaW5saW5lCitpbnQgcm1uZXRfaXNfcmVhbF9kZXZfcmVnaXN0ZXJlZChjb25zdCBzdHJ1Y3Qg bmV0X2RldmljZSAqcmVhbF9kZXYpCit7CisJcmV0dXJuIDA7Cit9CisjZW5kaWYKKworI2VuZGlm IC8qICEoX0xJTlVYX0lGX1JNTkVUX0hfKSAqLwotLSAKMS45LjEKCg== --=_710fa961174e63a42f89568769d53118--