From: David Ahern <dsahern@gmail.com>
To: Ido Schimmel <idosch@mellanox.com>, David Ahern <dsahern@kernel.org>
Cc: "davem@davemloft.net" <davem@davemloft.net>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Jiri Pirko <jiri@mellanox.com>,
Saeed Mahameed <saeedm@mellanox.com>
Subject: Re: [PATCH net-next 07/13] ipv6: Move gateway checks to a fib6_nh setting
Date: Wed, 27 Mar 2019 08:21:43 -0600 [thread overview]
Message-ID: <4b802f49-89b0-bc66-e76b-33ed17c19f08@gmail.com> (raw)
In-Reply-To: <20190327090759.GB15127@splinter>
On 3/27/19 3:08 AM, Ido Schimmel wrote:
> On Tue, Mar 26, 2019 at 08:29:36PM -0700, David Ahern wrote:
>> @@ -989,8 +989,11 @@ static void ip6_rt_copy_init(struct rt6_info *rt, struct fib6_info *ort)
>>
>> rt->rt6i_dst = ort->fib6_dst;
>> rt->rt6i_idev = dev ? in6_dev_get(dev) : NULL;
>> - rt->rt6i_gateway = ort->fib6_nh.nh_gw;
>> rt->rt6i_flags = ort->fib6_flags;
>> + if (ort->fib6_nh.fib_nh_has_gw) {
>> + rt->rt6i_gateway = ort->fib6_nh.nh_gw;
>> + rt->rt6i_flags |= RTF_GATEWAY;
>
> Not sure I understand why this line is needed. Can you explain?
The RTF_GATEWAY flag in an rt6_info still has many users.
>
>> + }
>> rt6_set_from(rt, ort);
>> #ifdef CONFIG_IPV6_SUBTREES
>> rt->rt6i_src = ort->fib6_src;
>> @@ -1870,7 +1873,7 @@ struct rt6_info *ip6_pol_route(struct net *net, struct fib6_table *table,
>
> ...
>
>> @@ -3134,7 +3138,7 @@ static struct fib6_info *ip6_route_info_create(struct fib6_config *cfg,
>> } else
>> rt->fib6_prefsrc.plen = 0;
>>
>> - rt->fib6_flags = cfg->fc_flags;
>> + rt->fib6_flags = cfg->fc_flags & ~RTF_GATEWAY;
>
> This is going to break mlxsw. See:
>
> mlxsw_sp_fib6_rt_can_mp()
> mlxsw_sp_rt6_is_gateway()
hmmm... not sure how I missed those. Will rescan the code for any other
missed checks on a fib6_info.
next prev parent reply other threads:[~2019-03-27 14:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-27 3:29 [PATCH net-next 00/13] net: Move fib_nh and fib6_nh to a common struct David Ahern
2019-03-27 3:29 ` [PATCH net-next 01/13] ipv4: Define fib_get_nhs when CONFIG_IP_ROUTE_MULTIPATH is disabled David Ahern
2019-03-27 7:40 ` Ido Schimmel
2019-03-27 3:29 ` [PATCH net-next 02/13] ipv4: Move IN_DEV_IGNORE_ROUTES_WITH_LINKDOWN to helper David Ahern
2019-03-27 7:44 ` Ido Schimmel
2019-03-27 3:29 ` [PATCH net-next 03/13] ipv4: Create init helper for fib_nh David Ahern
2019-03-27 8:12 ` Ido Schimmel
2019-03-27 14:17 ` David Ahern
2019-03-27 3:29 ` [PATCH net-next 04/13] ipv4: Create cleanup " David Ahern
2019-03-27 8:17 ` Ido Schimmel
2019-03-27 3:29 ` [PATCH net-next 05/13] ipv6: Create init helper for fib6_nh David Ahern
2019-03-27 8:34 ` Ido Schimmel
2019-03-27 3:29 ` [PATCH net-next 06/13] ipv6: Create cleanup " David Ahern
2019-03-27 8:38 ` Ido Schimmel
2019-03-27 14:17 ` David Ahern
2019-03-27 3:29 ` [PATCH net-next 07/13] ipv6: Move gateway checks to a fib6_nh setting David Ahern
2019-03-27 9:08 ` Ido Schimmel
2019-03-27 14:21 ` David Ahern [this message]
2019-03-27 3:29 ` [PATCH net-next 08/13] ipv6: Refactor fib6_ignore_linkdown David Ahern
2019-03-27 9:19 ` Ido Schimmel
2019-03-27 3:29 ` [PATCH net-next 09/13] ipv6: Change rt6_add_nexthop and rt6_nexthop_info to take fib6_nh David Ahern
2019-03-27 9:24 ` Ido Schimmel
2019-03-27 3:29 ` [PATCH net-next 10/13] ipv4: Rename fib_nh entries David Ahern
2019-03-27 3:29 ` [PATCH net-next 11/13] ipv6: Rename fib6_nh entries David Ahern
2019-03-27 3:29 ` [PATCH net-next 12/13] net: Add fib_nh_common and update fib_nh and fib6_nh David Ahern
2019-03-27 9:54 ` Ido Schimmel
2019-03-27 3:29 ` [PATCH net-next 13/13] net: Use common nexthop init and release helpers David Ahern
2019-03-27 9:46 ` Ido Schimmel
2019-03-27 14:22 ` David Ahern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4b802f49-89b0-bc66-e76b-33ed17c19f08@gmail.com \
--to=dsahern@gmail.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=idosch@mellanox.com \
--cc=jiri@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).