From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6F83C43381 for ; Wed, 27 Mar 2019 14:21:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B7C462075E for ; Wed, 27 Mar 2019 14:21:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VnIMFMpT" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728007AbfC0OVq (ORCPT ); Wed, 27 Mar 2019 10:21:46 -0400 Received: from mail-pl1-f193.google.com ([209.85.214.193]:43190 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727709AbfC0OVq (ORCPT ); Wed, 27 Mar 2019 10:21:46 -0400 Received: by mail-pl1-f193.google.com with SMTP id m10so3394687plt.10 for ; Wed, 27 Mar 2019 07:21:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Kn9wl4mPb7FLWcyGQ6XBwphCL0wAUqFoC62URC299hA=; b=VnIMFMpTBOZTdvheClADds2yBHDOYjWGm+AQIy5+7kLrzpkP2GhYSMEcXZYUwlMH9G uKImRcQYBkMyKPq1jlvZlTuXQndX/fyH3QVaYIfWgrmh2mqVt0gsLb0uwzhK2k6P5cqm vYsjw1DZqoKxbvc8xfobaXGdjDlZlpiErSTf8ZdwGr2+WVIrPXWku8jQ3ue2zJsStTRq b005DBDjp4+FZtGDYZv246TXUQ9UEVHrZeuz3cSBt6fh2KoQzW8TnPzk8Mbc5ru1Z42X EqVKCgirDo+Ox0e5fGcDwqGapv7755fcL5EBnjNTjzma1d9XwocQnnNQQ7EAHg8HYyRx vRFg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Kn9wl4mPb7FLWcyGQ6XBwphCL0wAUqFoC62URC299hA=; b=O+wiPsieHfoV/+p1MGcutZJyfZyVd3MSBT0P59BRSQ+j1oo1Xex2zbLLsyGaBz6D19 wq15oRnYBtyYp2Xkv+5TQiqrsUU4AnGub0U96TiMegsquU/rcEPC9KBJS9IBg6iHo+OV xM+wsjnf6PeeevdSvQqyeH/7hBQEeeCwuQoVFbK8/OovAfvGBmRu4Nmhhd26Fy8IQSgy eNds4RMYizP6ydB4IjxXMENB34ZgjjldnTuNtdmUD59j7eoGhf5VxbFqP6jFHIQq1dks jbzTUHkAgOf+dVNRwk5bNeVvNciTt/cK/lWYY5jkHoViuJ6B7H6AcJdzBsQAdPqCoTqU GOiQ== X-Gm-Message-State: APjAAAWiAB4g6wKGKDar904okrZ8tKCKUla3BazGWFW0m6c4wwEHDvD4 eXxk0kNT0GH9JoUcqW8SEjxFy9Rt X-Google-Smtp-Source: APXvYqzBSkCDEipb5dIPCmfT25GY4rzzZ1LE8v+0ZD2lscN6u7+OorIKGSfVALmabmaD50nLohTMQA== X-Received: by 2002:a17:902:9043:: with SMTP id w3mr37009415plz.101.1553696505689; Wed, 27 Mar 2019 07:21:45 -0700 (PDT) Received: from ?IPv6:2601:282:800:fd80:c1b3:1093:c763:b27f? ([2601:282:800:fd80:c1b3:1093:c763:b27f]) by smtp.googlemail.com with ESMTPSA id u13sm45048538pfa.169.2019.03.27.07.21.44 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 27 Mar 2019 07:21:44 -0700 (PDT) Subject: Re: [PATCH net-next 07/13] ipv6: Move gateway checks to a fib6_nh setting To: Ido Schimmel , David Ahern Cc: "davem@davemloft.net" , "netdev@vger.kernel.org" , Jiri Pirko , Saeed Mahameed References: <20190327032942.20473-1-dsahern@kernel.org> <20190327032942.20473-8-dsahern@kernel.org> <20190327090759.GB15127@splinter> From: David Ahern Message-ID: <4b802f49-89b0-bc66-e76b-33ed17c19f08@gmail.com> Date: Wed, 27 Mar 2019 08:21:43 -0600 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190327090759.GB15127@splinter> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 3/27/19 3:08 AM, Ido Schimmel wrote: > On Tue, Mar 26, 2019 at 08:29:36PM -0700, David Ahern wrote: >> @@ -989,8 +989,11 @@ static void ip6_rt_copy_init(struct rt6_info *rt, struct fib6_info *ort) >> >> rt->rt6i_dst = ort->fib6_dst; >> rt->rt6i_idev = dev ? in6_dev_get(dev) : NULL; >> - rt->rt6i_gateway = ort->fib6_nh.nh_gw; >> rt->rt6i_flags = ort->fib6_flags; >> + if (ort->fib6_nh.fib_nh_has_gw) { >> + rt->rt6i_gateway = ort->fib6_nh.nh_gw; >> + rt->rt6i_flags |= RTF_GATEWAY; > > Not sure I understand why this line is needed. Can you explain? The RTF_GATEWAY flag in an rt6_info still has many users. > >> + } >> rt6_set_from(rt, ort); >> #ifdef CONFIG_IPV6_SUBTREES >> rt->rt6i_src = ort->fib6_src; >> @@ -1870,7 +1873,7 @@ struct rt6_info *ip6_pol_route(struct net *net, struct fib6_table *table, > > ... > >> @@ -3134,7 +3138,7 @@ static struct fib6_info *ip6_route_info_create(struct fib6_config *cfg, >> } else >> rt->fib6_prefsrc.plen = 0; >> >> - rt->fib6_flags = cfg->fc_flags; >> + rt->fib6_flags = cfg->fc_flags & ~RTF_GATEWAY; > > This is going to break mlxsw. See: > > mlxsw_sp_fib6_rt_can_mp() > mlxsw_sp_rt6_is_gateway() hmmm... not sure how I missed those. Will rescan the code for any other missed checks on a fib6_info.