Re: [PATCH net-next 5/5] ionic: Add .get_fec_stats ethtool handler

Eric Joyner
2026-05-05T19:44:46Z

On 5/1/2026 4:41 PM, Jakub Kicinski wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
>
>
> On Thu, 30 Apr 2026 20:15:55 -0700 Eric Joyner wrote:
>> Several FEC error statistics being collected can be reported in a
>> dedicated ethtool callback for FEC errors, so implement the handler that
>> does so. This includes 802.3ck FEC histogram data that some newer
>> hardware collects.
>
> sparse says:
>
> drivers/net/ethernet/pensando/ionic/ionic_ethtool.c:449:37: warning: incorrect type in assignment (different base types)
> drivers/net/ethernet/pensando/ionic/ionic_ethtool.c:449:37: expected unsigned long long [usertype] sum
> drivers/net/ethernet/pensando/ionic/ionic_ethtool.c:449:37: got restricted __le64 const

Yeah, I'm missing a cpu_to_le64(); I'll add it in the next version of this patchset.

- Eric