* [PATCH] drivers/net/slip: Add space after that ',' [not found] <tencent_C824D439C8CE96AD83779E068967114FF105@qq.com> @ 2023-07-14 8:02 ` hanyu001 2023-07-15 3:36 ` Jakub Kicinski 0 siblings, 1 reply; 3+ messages in thread From: hanyu001 @ 2023-07-14 8:02 UTC (permalink / raw) To: davem, edumazet, kuba, pabeni; +Cc: netdev, linux-kernel Fix Error reported by checkpatch.pl ./drivers/net/slip/slhc.c:381: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: maqimei <2433033762@qq.com> --- drivers/net/slip/slhc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/slip/slhc.c b/drivers/net/slip/slhc.c index befdf4a..cf0245a 100644 --- a/drivers/net/slip/slhc.c +++ b/drivers/net/slip/slhc.c @@ -378,7 +378,7 @@ struct slcompress * goto uncompressed; } if((deltaS = ntohs(th->window) - ntohs(oth->window)) != 0){ - cp = encode(cp,deltaS); + cp = encode(cp, deltaS); changes |= NEW_W; } if((deltaA = ntohl(th->ack_seq) - ntohl(oth->ack_seq)) != 0L){ ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/slip: Add space after that ',' 2023-07-14 8:02 ` [PATCH] drivers/net/slip: Add space after that ',' hanyu001 @ 2023-07-15 3:36 ` Jakub Kicinski 0 siblings, 0 replies; 3+ messages in thread From: Jakub Kicinski @ 2023-07-15 3:36 UTC (permalink / raw) To: hanyu001; +Cc: davem, edumazet, pabeni, netdev, linux-kernel On Fri, 14 Jul 2023 16:02:13 +0800 hanyu001@208suo.com wrote: > Fix Error reported by checkpatch.pl > > ./drivers/net/slip/slhc.c:381: ERROR: space required after that ',' > (ctx:VxV) Don't send checkpatch fixes to networking, thanks. ^ permalink raw reply [flat|nested] 3+ messages in thread
[parent not found: <tencent_222320492FD62B52855A0449D87275D0CD0A@qq.com>]
* [PATCH] drivers/net/slip: Add space after that ',' [not found] <tencent_222320492FD62B52855A0449D87275D0CD0A@qq.com> @ 2023-07-14 7:51 ` hanyu001 0 siblings, 0 replies; 3+ messages in thread From: hanyu001 @ 2023-07-14 7:51 UTC (permalink / raw) To: davem, edumazet, kuba, pabeni; +Cc: linux-kernel, netdev Fix Error reported by checkpatch.pl ./drivers/net/slip/slhc.c:476: ERROR: space required after that ',' (ctx:VxV) ./drivers/net/slip/slhc.c:476: ERROR: space required after that ',' (ctx:VxV) ./drivers/net/slip/slhc.c:477: ERROR: space required after that ',' (ctx:VxV) ./drivers/net/slip/slhc.c:477: ERROR: space required after that ',' (ctx:VxV) Signed-off-by: maqimei <2433033762@qq.com> --- drivers/net/slip/slhc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/slip/slhc.c b/drivers/net/slip/slhc.c index 0011915..befdf4a 100644 --- a/drivers/net/slip/slhc.c +++ b/drivers/net/slip/slhc.c @@ -473,8 +473,8 @@ struct slcompress * * to use on future compressed packets in the protocol field). */ uncompressed: - memcpy(&cs->cs_ip,ip,20); - memcpy(&cs->cs_tcp,th,20); + memcpy(&cs->cs_ip, ip, 20); + memcpy(&cs->cs_tcp, th, 20); if (ip->ihl > 5) memcpy(cs->cs_ipopt, ip+1, ((ip->ihl) - 5) * 4); if (th->doff > 5) ^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-07-15 3:36 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <tencent_C824D439C8CE96AD83779E068967114FF105@qq.com>
2023-07-14 8:02 ` [PATCH] drivers/net/slip: Add space after that ',' hanyu001
2023-07-15 3:36 ` Jakub Kicinski
[not found] <tencent_222320492FD62B52855A0449D87275D0CD0A@qq.com>
2023-07-14 7:51 ` hanyu001
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).