From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3819FC77B73 for ; Thu, 13 Apr 2023 16:11:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230115AbjDMQLG (ORCPT ); Thu, 13 Apr 2023 12:11:06 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49776 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230106AbjDMQKx (ORCPT ); Thu, 13 Apr 2023 12:10:53 -0400 Received: from mail-wr1-x431.google.com (mail-wr1-x431.google.com [IPv6:2a00:1450:4864:20::431]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 626DACF; Thu, 13 Apr 2023 09:10:52 -0700 (PDT) Received: by mail-wr1-x431.google.com with SMTP id w24so5138600wra.10; Thu, 13 Apr 2023 09:10:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681402251; x=1683994251; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=xxhfaeVmSMj1ooJ+GI5JYtziwZS5hnJz5+YIfhecAsY=; b=JZGS3Cx9dJu4XC/Z2tGHpQhSaw4QPoqfih9/B5HS4OW/nWd5q4b1LQsavW/EG1VKTK P0/5/utyOkzKjMKz0ry5WoJKUrMbj7T0EAZUqqmzFQ3EkNav2dQUf2fCAggccYt6Np1g gvFyaIzDa/Shb0tRlWshEcoUxQN0p/2OPcZjaLkAORwPJ0ZWqm/GobyuU0YKSYNB6+rA Nqo/9QEVcqDM5EczCK0vLsGOWfzkRTvygNyERGSE904FW1xZfXejqIoT+D5TfdDK78/K XF+4NhPpx7OnACQDNCtP1fxVcSZPQaq1/lz5sBIHXuoVNp3Y+XlFQxNaari3xVSoqxgH aSDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1681402251; x=1683994251; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xxhfaeVmSMj1ooJ+GI5JYtziwZS5hnJz5+YIfhecAsY=; b=OnGcqKtsRk/7k1VNYpufdliAjdZ4z0NcSF9TT+lqHyN0iCcb0xfeeLywnH3qvPjTpp L7kf/eueE9yLkhIHhXr20x5t+TD8h0P5Y6yDZBmcajjYKA0pe5yb4+TpKoxEWHA3Q3Hb xbyOsbIXfelhgqAaSKqQ4yioIZV0QU61IJP2Nv0JVGFXNSiW7O1NJtLQzE/JdQj2rD1x cpj4n8AlTuPvDb71Se6saLKBL87oFUWxrtN7lYyFAf13+4SSYaZ0mweXj5g6kNdZo+R8 JYd02YnyaD40b8dDt4OxDn78gSwpyNWWuT6qqfHxGxI/glS9z6kNvuoHk2Cb6zCB/1HW Hmsg== X-Gm-Message-State: AAQBX9f7FaBmvGJKkSAI3SeOR9vXBW91oJ/6aJpGGZA9VCl7YHul2H14 Qw++vu2h5XR4TTaHCj4+gV0= X-Google-Smtp-Source: AKy350ZmL0jv9Fv0h834EwT/L4/OH9X+H2tpoq3EcZanDBDsPudFnSBoOEgKQrERrEaFMWdGIfwBYg== X-Received: by 2002:a5d:6450:0:b0:2f0:15b8:d2a3 with SMTP id d16-20020a5d6450000000b002f015b8d2a3mr2047445wrw.29.1681402250871; Thu, 13 Apr 2023 09:10:50 -0700 (PDT) Received: from localhost ([102.36.222.112]) by smtp.gmail.com with ESMTPSA id z1-20020a5d4d01000000b002e5f6f8fc4fsm1563370wrt.100.2023.04.13.09.10.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 13 Apr 2023 09:10:50 -0700 (PDT) Date: Thu, 13 Apr 2023 19:10:47 +0300 From: Dan Carpenter To: Ladislav Michl Cc: linux-staging@lists.linux.dev, netdev@vger.kernel.org, linux-mips@vger.kernel.org, Chris Packham Subject: Re: [RFC 3/3] staging: octeon: convert to use phylink Message-ID: <4ba4bab4-c9ab-468f-ac35-510612529b89@kili.mountain> References: <0af60abb-d599-4fdd-9bf6-ccf14524fe44@kili.mountain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Thu, Apr 13, 2023 at 06:04:47PM +0200, Ladislav Michl wrote: > > > diff --git a/drivers/staging/octeon/ethernet-rgmii.c b/drivers/staging/octeon/ethernet-rgmii.c > > > index 0c4fac31540a..8c6eb0b87254 100644 > > > --- a/drivers/staging/octeon/ethernet-rgmii.c > > > +++ b/drivers/staging/octeon/ethernet-rgmii.c > > > @@ -115,17 +115,8 @@ static void cvm_oct_rgmii_poll(struct net_device *dev) > > > > > > cvm_oct_check_preamble_errors(dev); > > > > > > - if (likely(!status_change)) > > ^ > > Negated. > > On purpose. > > > > - return; > > > - > > > - /* Tell core. */ > > > - if (link_info.s.link_up) { > > > - if (!netif_carrier_ok(dev)) > > > - netif_carrier_on(dev); > > > - } else if (netif_carrier_ok(dev)) { > > > - netif_carrier_off(dev); > > > - } > > > - cvm_oct_note_carrier(priv, link_info); > > > + if (likely(status_change)) > > > > Originally a status_change was unlikely but now it is likely. > > Yes, but originally it returned after condition and now it executes > phylink_mac_change. This is just to emulate current bahaviour. > Later mac interrupts should be used to drive link change. I don't think you have seen the (minor) issue. Originally it was likely that status_change was NOT set. But now it is likely that is *IS* set. regards, dan carpenter