From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D9AEFC433EF for ; Wed, 6 Apr 2022 11:32:36 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237610AbiDFLec (ORCPT ); Wed, 6 Apr 2022 07:34:32 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42110 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233615AbiDFLcY (ORCPT ); Wed, 6 Apr 2022 07:32:24 -0400 Received: from mail-ej1-x631.google.com (mail-ej1-x631.google.com [IPv6:2a00:1450:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7475443AD1E for ; Wed, 6 Apr 2022 01:20:49 -0700 (PDT) Received: by mail-ej1-x631.google.com with SMTP id ot30so2587692ejb.12 for ; Wed, 06 Apr 2022 01:20:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :cc:references:from:in-reply-to:content-transfer-encoding; bh=nwwNMDaP5Yh8K0WaZWOfIjXkdwXbq5VOVV+PO+4zCEI=; b=t7z1bs+kTqbj1INwRe1vMtQ6NKc9uAcZwKH60yfxmMmMEUv5b2KMB9WrLTjgP48JEr yJSUf9ilQz0NsSCbqfCtGk3S5Y6RMpHcFgypLxDLY4xXto8of3uXP8OhAa2JlUVZd+z+ STDLjB7eUkYmPVJ/dKPcvWdoR2MzbknsovOOYDkfvdgAXybQnXF7QXhp3uK8KBx6bBwN yW0SOxMHKO46Pqx08IvSKm5rFKwocFHce2EocdmglFWZsyYKaiCGogjwQ7jlTLu39I0y 0RSfqUSdfO6qX/snMr/HH0+KQ9C2V+oUnfDIFX94aNbg6t6wQ+loyiy7hOx/mqPT+n1d WwyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=nwwNMDaP5Yh8K0WaZWOfIjXkdwXbq5VOVV+PO+4zCEI=; b=mASvNNqHjO3kgN/qkgMBwXtUjqsEN/J7W3a/v6Rymjm61eVZvqA+wxJlKOKLlUnMjY ZuF4JaFhxurRMrMRJwM4lv5wLRqFsRvyhDRS//8YnCKjktlmw/GyUeHIu4SkLgQVV1QG ijksgfbSCi/Zq6CAplwB+pWuP8Z8BADvmqgdFlWnCI6jF+DxgBUfE+goQcKr7QAoXs5G qUyk1VjRfinWhFYzWJ+ic35Zmg8kW6DOThQNrglCV2vew2USP43zsxaTAvm+pLm1kHFQ 9vZi+oksfv2M+PRdCVyroRmHCm/EpVoKq9SaW6t9XcsPN5WTCEM2B7uz/W33xrcBRBSt V2ow== X-Gm-Message-State: AOAM532F/GVHL57tnZdISey/CKwK7glgYmJ5W7yl9v/vcTyb4wLi1TvQ 0qTx/98fT14/A6JxOhLrJD6bdw== X-Google-Smtp-Source: ABdhPJwXpHbNbl+9gjYwq/xSxgHmjmznGjTieI5zwK9DQvHmBWZLhxJmk6snQcc/KpO8olUy4KkMhg== X-Received: by 2002:a17:906:7304:b0:6da:9243:865 with SMTP id di4-20020a170906730400b006da92430865mr7135579ejc.665.1649233248063; Wed, 06 Apr 2022 01:20:48 -0700 (PDT) Received: from [192.168.0.182] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.gmail.com with ESMTPSA id dm11-20020a170907948b00b006cf488e72e3sm6347202ejc.25.2022.04.06.01.20.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 06 Apr 2022 01:20:47 -0700 (PDT) Message-ID: <4bafe244-6a3d-d0ec-59d3-3f3f00e71caf@linaro.org> Date: Wed, 6 Apr 2022 10:20:46 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH v2 05/14] dt-bindings: arm: mediatek: document the pcie mirror node on MT7622 Content-Language: en-US To: Felix Fietkau , netdev@vger.kernel.org, Rob Herring , Krzysztof Kozlowski , Matthias Brugger , "David S. Miller" , Jakub Kicinski , Paolo Abeni , Lorenzo Bianconi Cc: devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220405195755.10817-1-nbd@nbd.name> <20220405195755.10817-6-nbd@nbd.name> From: Krzysztof Kozlowski In-Reply-To: <20220405195755.10817-6-nbd@nbd.name> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 05/04/2022 21:57, Felix Fietkau wrote: > From: Lorenzo Bianconi > > This patch adds the pcie mirror document bindings for MT7622 SoC. > The feature is used for intercepting PCIe MMIO access for the WED core > Add related info in mediatek-net bindings. > > Signed-off-by: Lorenzo Bianconi > Signed-off-by: Felix Fietkau > --- > .../mediatek/mediatek,mt7622-pcie-mirror.yaml | 42 +++++++++++++++++++ Eh, I wanted to ask to not put it inside arm/, but judging by your usage - you did not create drivers for both of these (WED and PCIe mirror). You only need them to expose address spaces via syscon. This actually looks hacky. Either WED and PCIe mirror are part of network driver, then add the address spaces via "reg". If they are not, but instead they are separate blocks, why you don't have drivers for them? Best regards, Krzysztof