netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Tony Chuang <yhchuang@realtek.com>
To: Kalle Valo <kvalo@codeaurora.org>, Randy Dunlap <rdunlap@infradead.org>
Cc: "Mancini, Jason" <Jason.Mancini@amd.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-wireless@vger.kernel.org" <linux-wireless@vger.kernel.org>
Subject: RE: v5.5-rc1 and beyond insta-kills some Comcast wifi routers
Date: Wed, 4 Mar 2020 05:16:37 +0000	[thread overview]
Message-ID: <4bd036de86c94545af3e5d92f0920ac2@realtek.com> (raw)
In-Reply-To: <87h7z4r9p5.fsf@kamboji.qca.qualcomm.com>

Kalle Valo <kvalo@codeaurora.org> writes:
> 
> Randy Dunlap <rdunlap@infradead.org> writes:
> 
> > [add netdev mailing list + 2 patch signers]
> 
> Adding also linux-wireless. It's always best to send questions about any
> wireless issues to linux-wireless
> 
> > On 3/3/20 7:34 PM, Mancini, Jason wrote:
> >> [I can't seem to access the linux-net ml per kernel.org faq, apology
> >> in advance.]
> >>
> >> This change, which I think first appeared for v5.5-rc1, basically
> >> within seconds, knocks out our [apparently buggy] Comcast wifi for
> >> about 2-3 minutes.  Is there a boot option (or similar) where I can
> >> achieve prior kernel behavior?  Otherwise I am stuck on kernel 5.4
> >> (or Win10) it seems, or forever compiling custom kernels for my
> >> choice of distribution [as I don't have physical access to the router
> >> in question.]
> >> Thanks!
> >> Jason
> >>
> >> ================
> >>
> >> 127eef1d46f80056fe9f18406c6eab38778d8a06 is the first bad commit
> >> commit 127eef1d46f80056fe9f18406c6eab38778d8a06
> >> Author: Yan-Hsuan Chuang <yhchuang@realtek.com>
> >> Date:   Wed Oct 2 14:35:23 2019 +0800
> 
> Can you try if this fixes it:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/kvalo/wireless-drivers-next.gi
> t/commit/?id=74c3d72cc13401f9eb3e3c712855e9f8f2d2682b
> 

Kalle is providing the right possible patch to fix it.

The first bad commit you found, that causes this issue, introduced TX-AMSDU.
But we found that enabling TX-AMSDU on 2.4G band is not working while
connecting to some APs. So, you can try if the patch provided by Kalle works.
(I hope so). Otherwise, you can enable the kernel log debug mask by:
echo 0xffffffff > /sys/module/rtw88/parameters/debug_mask.
And collect the log to see if there's anything wrong.

Yen-Hsuan

  reply	other threads:[~2020-03-04  5:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <DM6PR12MB4331FD3C4EF86E6AF2B3EBC7E5E50@DM6PR12MB4331.namprd12.prod.outlook.com>
2020-03-04  4:05 ` v5.5-rc1 and beyond insta-kills some Comcast wifi routers Randy Dunlap
2020-03-04  5:05   ` Kalle Valo
2020-03-04  5:16     ` Tony Chuang [this message]
2020-03-04  9:03       ` Mancini, Jason
2020-03-04 10:41         ` Tony Chuang
2020-03-05  7:06           ` Jason Mancini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4bd036de86c94545af3e5d92f0920ac2@realtek.com \
    --to=yhchuang@realtek.com \
    --cc=Jason.Mancini@amd.com \
    --cc=kvalo@codeaurora.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).