From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F5F7C43381 for ; Wed, 6 Mar 2019 22:34:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1B9F220663 for ; Wed, 6 Mar 2019 22:34:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="FtPX/nv8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727442AbfCFWe1 (ORCPT ); Wed, 6 Mar 2019 17:34:27 -0500 Received: from mail-pg1-f173.google.com ([209.85.215.173]:46317 "EHLO mail-pg1-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726715AbfCFWe1 (ORCPT ); Wed, 6 Mar 2019 17:34:27 -0500 Received: by mail-pg1-f173.google.com with SMTP id 196so9557903pgf.13 for ; Wed, 06 Mar 2019 14:34:27 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=INr9iJz/Kui4bzSKm0NqmgGKtStAUKkv6kjtufRN7RA=; b=FtPX/nv8axNemSfIAoyQOLln+HsEIqm856Q2i+4WGzDbOylHKnsNWs9mYRFHYh54j0 hy5+JeyC4pVq4IxXF3FW7U7fTgJLZWLbuy/RVgt6jAmIsiLM5yJoqgjEVXtASt3AR85z 461JD87aCw2bleHcC4fFKbQNvPBNG6wFfD2PEejaYY410fWDpNDrDiK9Z8bQoealq9Q6 FI1CxzNT8rRjggjD60uj2CinMMPsbAiEg3pkyLwUi2d1Z1f2wMrJWezB2vnsZkjjT0yg KYura2GZTCg3Cm3Ysnk2ILxDrjnOw290z8NcV9k4knwSsdyf+J1OJhxG4ytC6ndM6+Pt pH/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=INr9iJz/Kui4bzSKm0NqmgGKtStAUKkv6kjtufRN7RA=; b=rlmLKy3o9wU+wTs9WEkvOF1feVjUMCNazHORh682kMnw22lBylV89SaEqgZE8B8lm9 HhJWcWUW2jkw9ZG6zx0kOn6SE5LGs2Icqzq1IiGz3CiLey8n8nXWqQE/ffNVL4fNQA9i lQqMrhekiPr6A47ZcNKkNUIS2HnMhtOZXhnU28PJu5+go/GcWeFi3flNP1V0TTDMhGbT BcQUgKyMKoM7MTxedFSbVDdPWkrcFAOkcdBPQ/eMc3TWo38AhQM26a6YHkqqNFAtRFse iI9PuTWfLKJ3EGyT28tjqwUX36vfhbcjYG3Gc6Ixkk0vVkgAQ7pOQrT4sMLcJE8xvT98 lJ6w== X-Gm-Message-State: APjAAAV8t9LFCa7IukdUxhBVZ1GQytcLq6OxOxKGv+4vPjIW2C0rqwIn QwL7ska94qoZ5RB8jZqrbggBd322 X-Google-Smtp-Source: APXvYqzcGdhIy0eTAt/XHt2N6eSVAnmKnrbuH1Z7MACYQ/alqHglVw+KcEEp1U9hERyiXL82IaxKlw== X-Received: by 2002:a62:1c94:: with SMTP id c142mr9903322pfc.54.1551911666727; Wed, 06 Mar 2019 14:34:26 -0800 (PST) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id g69sm6681508pfd.168.2019.03.06.14.34.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Mar 2019 14:34:26 -0800 (PST) Subject: Re: TAHI testing fails for IPv6 Fragments in Kernel 4.9 To: David Miller , captwiggum@gmail.com Cc: netdev@vger.kernel.org References: <20190306.142818.1045935324715292108.davem@davemloft.net> From: Eric Dumazet Message-ID: <4be8c46a-6231-6e7b-8cd7-0a2efab07caa@gmail.com> Date: Wed, 6 Mar 2019 14:34:25 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190306.142818.1045935324715292108.davem@davemloft.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 03/06/2019 02:28 PM, David Miller wrote: > From: Captain Wiggum > Date: Wed, 6 Mar 2019 15:26:43 -0700 > >> We are using the TAHI Self-test tools from IPv6 Ready Logo Program: >> https://www.ipv6ready.org/?page=documents&tag=ipv6-core-protocols >> >> The test passed up to 4.9.133, then fails ever since. >> >> The are about 20 failing test cases regarding IPv6 fragments, >> where the kernel is issuing an ICMPv6 parameter problem pointing >> to the Fragmentation Header. >> >> I see lots of commits regarding improving fragment processing. >> Has anyone else run TAHI tests on kernel 4.9 or later? >> Is there any interest in looking into this to improve >> the IPv6 functionality? > > It is intentionally failing those tests to fix a denial of service > issue with ipv6 fragmentation and this will therefore not be changed. That was Florian patch that was later reverted, right ? 0ed4229b08c13c84a3c301a08defdc9e7f4467e6 ipv6: defrag: drop non-last frags smaller than min mtu -> reverted in d4289fcc9b16b89619ee1c54f829e05e56de8b9a net: IP6 defrag: use rbtrees for IPv6 defrag