From: Andrew Lunn <andrew@lunn.ch>
To: Joel <joelcrouch@gmail.com>
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sungem: fix PHY initialization hardware failure check and pointe style
Date: Thu, 2 Apr 2026 22:04:11 +0200 [thread overview]
Message-ID: <4c17e602-e9ba-4ea5-993f-27a221a24ea0@lunn.ch> (raw)
In-Reply-To: <20260402194235.11986-1-joelcrouch@gmail.com>
On Thu, Apr 02, 2026 at 07:42:35PM +0000, Joel wrote:
> Currently, bcm5411_init does not validate the result of the PHY register
> reads. This can lead to silent failures if the hardware is unresponsive
> or the MDIO bus times out, as 0xffff would be treated as valid data.
>
> This patch:
> 1: Adds a check for -EIO and 0xffff during BCM5411 initialization.
> 2: Updates gem_init_phy to log an error message fi the PHY-
> specific init fails.
> 3: Cleans up pointer formatting(eg,. foo* bar to foo *bar) to
> align with Linux Kernel Coding Style in the modified files.
A patch which does three things should probably be three patches. We
want lots of small patches, with good commit messages, which are
obviously correct.
Code style changes should definitely be in a different patch to real
changes.
https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
Andrew
---
pw-bot: cr
prev parent reply other threads:[~2026-04-02 20:04 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-02 19:42 [PATCH] sungem: fix PHY initialization hardware failure check and pointe style Joel
2026-04-02 20:04 ` Andrew Lunn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c17e602-e9ba-4ea5-993f-27a221a24ea0@lunn.ch \
--to=andrew@lunn.ch \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=joelcrouch@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox